linux-kernel - Re: cocci script from 2016

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <027076b1335f3b48307c78a3d6d1573fa8975822.camel@perches.com>
Date:   Thu, 25 Jun 2020 00:49:10 -0700
From:   Joe Perches <joe@...ches.com>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     Kris Borer <kborer@...il.com>,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: cocci script from 2016 - assignment in if ?

On Thu, 2020-06-25 at 08:49 +0200, Julia Lawall wrote:
> 
> On Wed, 24 Jun 2020, joe@...ches.com wrote:
> 
> > https://lore.kernel.org/patchwork/patch/649705/
> > 
> > Any particular reason this wasn't applied?
> > 
> > I ask because I added something similar recently to checkpatch.
> 
> It probably slipped through the cracks at the time the Coccinelle
> scripts maintainer disappeared.  I can check and see if it does anything
> more than your script.

The checkpatch thing only works on single lines,
so this cocci script looks more whitespace robust
but this script doesn't appear to handle code like

	if (!(foo = bar(...)))
		baz;

where the checkpatch thing converts it OK.