[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3700a9b7-195b-f8d6-de03-fc5a77beffee@collabora.com>
Date: Thu, 25 Jun 2020 10:40:40 +0200
From: Enric Balletbo i Serra <enric.balletbo@...labora.com>
To: Matthias Brugger <matthias.bgg@...il.com>,
linux-kernel@...r.kernel.org
Cc: Collabora Kernel ML <kernel@...labora.com>, erwanaliasr1@...il.com,
drinkcat@...omium.org, hsinyi@...omium.org,
Ben Ho <Ben.Ho@...iatek.com>, Rob Herring <robh+dt@...nel.org>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 7/7] arm64: dts: mt8183: Add krane-sku176 board
Hi Matthias,
Thank you for your review.
On 22/6/20 12:33, Matthias Brugger wrote:
>
>
> On 19/06/2020 12:27, Enric Balletbo i Serra wrote:
>> Also known as the Lenovo IdeaPad Duet Chromebook.
>>
>> There are different krane boards with shared resources, hence a
>> mt8183-kukui-krane.dtsi was created for easily introduce future new
>> boards. The same happens with the baseboard codenamed kukui where
>> different variants, apart from kukui variant can take advantage of the
>> shared resources.
>>
>> Signed-off-by: Ben Ho <Ben.Ho@...iatek.com>
>> [originally created by Ben Ho but adapted and ported to mainline]
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
>> ---
>>
>> arch/arm64/boot/dts/mediatek/Makefile | 1 +
>> .../mediatek/mt8183-kukui-krane-sku176.dts | 18 +
>> .../boot/dts/mediatek/mt8183-kukui-krane.dtsi | 343 ++++++++
>> .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 788 ++++++++++++++++++
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
>> 5 files changed, 1151 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts
>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>
> [...]
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> new file mode 100644
>> index 0000000000000..f0a070535b340
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> [...]
>> +
>> + max98357a: codec0 {
>> + compatible = "maxim,max98357a";
>> + sdmode-gpios = <&pio 175 0>;
>> + };
>> +
>> + btsco: codec1 {
>
> bt_sco_codec:
> is more clear, I think.
>
Ok. I'll change that in next version.
>> + compatible = "linux,bt-sco";
>> + };
>> +
>> + wifi_pwrseq: wifi-pwrseq {
>> + compatible = "mmc-pwrseq-simple";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&wifi_pins_pwrseq>;
>> +
>> + /* Toggle WIFI_ENABLE to reset the chip. */
>> + reset-gpios = <&pio 119 1>;
>> + };
>> +
> [...]> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index a1576f1b5a447..689bce13e0165 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -719,6 +719,7 @@ u3phy: usb-phy@...40000 {
>> compatible = "mediatek,mt8183-tphy",
>> "mediatek,generic-tphy-v2";
>> #address-cells = <1>;
>> + #phy-cells = <1>;
>
> Wrong patch?
>
Oh yes, this should go with the USB one. Thank you to catch this, I'll fix in
next version.
>> #size-cells = <1>;
>> ranges = <0 0 0x11f40000 0x1000>;
>> status = "okay";
>>
>
> Regards,
> Matthias
>
Powered by blists - more mailing lists