linux-kernel - Re: Search function in xconfig is partially broken after recent changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Jun 2020 13:17:58 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To:     Maxim Levitsky <mlevitsk@...hat.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: Search function in xconfig is partially broken after recent
 changes

Em Thu, 25 Jun 2020 12:59:15 +0200
Mauro Carvalho Chehab <mchehab+huawei@...nel.org> escreveu:

> Hi Maxim,
> 
> Em Thu, 25 Jun 2020 12:25:10 +0300
> Maxim Levitsky <mlevitsk@...hat.com> escreveu:
> 
> > Hi!
> > 
> > I noticed that on recent kernels the search function in xconfig is partially broken.
> > This means that when you select a found entry, it is not selected in the main window,
> > something that I often do to find some entry near the area I would like to modify,
> > and then use main window to navigate/explore that area.
> > 
> > Reverting these commits helps restore the original behavier:
> > 
> > b311142fcfd37b58dfec72e040ed04949eb1ac86 - kconfig: qconf: fix support for the split view mode
> > cce1faba82645fee899ccef5b7d3050fed3a3d10 - kconfig: qconf: fix the content of the main widget
> > 
> > I have Qt5 5.13.2 from fedora 31 (5.13.2-1.fc31)
> > 
> > Could you explain what these commits are supposed to fix?
> > I mostly use the split view mode too and it does appear to work for me with these commits reverted as well.
> > 
> 
> There are three view modes for qconf:
> 
> 	- Single
> 	- Split
> 	- Full
> 
> those got broken when gconf was converted to use Qt5, back on Kernel 3.14.
> Those patches restore the original behavior.
> 
> > Another question is do you know how to run the qconf standalone? It appears to crash when I attempt to do so,
> > althought I checked that I pass correct command line to it, and use the same current directory.
> > I guess PATH or something is set by the makefile, but I was unable yet to find out what exactly breaks it.
> > 
> > This is what I see:
> > 
> > [mlevitsk@...rship ~/UPSTREAM/linux-kernel/src]$./scripts/kconfig/qconf Kconfig
> > sh: /scripts/gcc-version.sh: No such file or directory
> > init/Kconfig:34: syntax error
> > init/Kconfig:33: invalid statement
> > init/Kconfig:34: invalid statement
> > sh: /scripts/ld-version.sh: No such file or directory
> > sh: --version: command not found
> > init/Kconfig:39: syntax error
> > init/Kconfig:38: invalid statement
> > sh: /scripts/clang-version.sh: No such file or directory
> > init/Kconfig:49: syntax error
> > init/Kconfig:48: invalid statement
> > Recursive inclusion detected.
> > Inclusion path:
> 
> It requires some environment vars. This would make it a little better:
> 
> 
> 	export LD=$(which ldd); export CC=$(which gcc); export srctree=$(pwd); scripts/kconfig/gconf Kconfig
> 	Recursive inclusion detected.
> 	Inclusion path:
> 	  current file : arch//Kconfig
> 	  included from: arch//Kconfig:10
> 
> but it seems that something else is also needed.

This worked for me:

	SRCARCH=x86 LD=$(which ldd) CC=$(which gcc) srctree=$(pwd) scripts/kconfig/gconf Kconfig

Thanks,
Mauro