linux-kernel - Re: [PATCH] KVM: x86: Use VMCALL and VMMCALL mnemonics in kvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30a01d1f-5b36-5171-3d0a-e14fa7afa62e@redhat.com>
Date:   Thu, 25 Jun 2020 14:32:55 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Uros Bizjak <ubizjak@...il.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86: Use VMCALL and VMMCALL mnemonics in kvm_para.h

On 23/06/20 20:34, Uros Bizjak wrote:
> Current minimum required version of binutils is 2.23,
> which supports VMCALL and VMMCALL instruction mnemonics.
> 
> Replace the byte-wise specification of VMCALL and
> VMMCALL with these proper mnemonics.
> 
> Signed-off-by: Uros Bizjak <ubizjak@...il.com>
> CC: Paolo Bonzini <pbonzini@...hat.com>
> ---
>  arch/x86/include/asm/kvm_para.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/kvm_para.h b/arch/x86/include/asm/kvm_para.h
> index 49d3a9edb06f..01317493807e 100644
> --- a/arch/x86/include/asm/kvm_para.h
> +++ b/arch/x86/include/asm/kvm_para.h
> @@ -18,7 +18,7 @@ static inline bool kvm_check_and_clear_guest_paused(void)
>  #endif /* CONFIG_KVM_GUEST */
>  
>  #define KVM_HYPERCALL \
> -        ALTERNATIVE(".byte 0x0f,0x01,0xc1", ".byte 0x0f,0x01,0xd9", X86_FEATURE_VMMCALL)
> +        ALTERNATIVE("vmcall", "vmmcall", X86_FEATURE_VMMCALL)
>  
>  /* For KVM hypercalls, a three-byte sequence of either the vmcall or the vmmcall
>   * instruction.  The hypervisor may replace it with something else but only the
> 

Queued, thanks.