linux-kernel - Re: [PATCH] phy: sun4i-usb: fix dereference of pointer phy0 before it is null checked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200625125655.GC6228@vkoul-mobl>
Date:   Thu, 25 Jun 2020 18:26:55 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        linux-arm-kernel@...ts.infradead.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: sun4i-usb: fix dereference of pointer phy0 before
 it is null checked

On 25-06-20, 13:44, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently pointer phy0 is being dereferenced via the assignment of
> phy on the call to phy_get_drvdata before phy0 is null checked, this
> can lead to a null pointer dereference. Fix this by performing the
> null check on phy0 before the call to phy_get_drvdata. Also replace
> the phy0 == NULL check with the more usual !phy0 idiom.

Applied, thanks
-- 
~Vinod