linux-kernel - Re: [PATCH] staging: gasket: Convert symbolic permission to octal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200625133604.GA3533051@kroah.com>
Date:   Thu, 25 Jun 2020 15:36:04 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Brooke Basile <brookebasile@...il.com>
Cc:     rspringer@...gle.com, toddpoynor@...gle.com, benchan@...omium.org,
        rcy@...gle.com, devel@...verdev.osuosl.org, trivial@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gasket: Convert symbolic permission to octal

On Thu, Jun 25, 2020 at 09:25:13AM -0400, Brooke Basile wrote:
> Fixing checkpatch WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> 
> Signed-off-by: Brooke Basile <brookebasile@...il.com>
> ---
>  drivers/staging/gasket/gasket_sysfs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h
> index ab5aa351d555..eb0fd3b0490f 100644
> --- a/drivers/staging/gasket/gasket_sysfs.h
> +++ b/drivers/staging/gasket/gasket_sysfs.h
> @@ -71,7 +71,7 @@ struct gasket_sysfs_attribute {
>  
>  #define GASKET_SYSFS_RO(_name, _show_function, _attr_type)                     \
>  	{                                                                      \
> -		.attr = __ATTR(_name, S_IRUGO, _show_function, NULL),          \
> +		.attr = __ATTR(_name, 0444, _show_function, NULL),	       \
>  		.data.attr_type = _attr_type                                   \
>  	}

Someone else sent this a few days before you did:
	 https://lore.kernel.org/r/20200622073612.12282-1-rodolfovillordo@gmail.com

sorry,

greg k-h