linux-kernel - Re: [PATCH V2] firmware: imx: Move i.MX SCU soc driver into imx firmware folder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Jun 2020 17:15:32 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Anson Huang <anson.huang@....com>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Leo Li <leoyang.li@....com>, Vinod Koul <vkoul@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Olof Johansson <olof@...om.net>, Peng Fan <peng.fan@....com>,
        Aisheng Dong <aisheng.dong@....com>,
        Daniel Baluta <daniel.baluta@....com>,
        Franck Lenormand <franck.lenormand@....com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH V2] firmware: imx: Move i.MX SCU soc driver into imx
 firmware folder

On Thu, Jun 25, 2020 at 2:54 PM Anson Huang <anson.huang@....com> wrote:
> > Subject: Re: [PATCH V2] firmware: imx: Move i.MX SCU soc driver into imx firmware folder
> > On Thu, Jun 25, 2020 at 2:27 AM Anson Huang <Anson.Huang@....com>
> > wrote:

> > This makes separate loadable modules out of the driver when
> > CONFIG_IMX_SCU=m, including the badly named misc.ko and rm.ko modules
> > that might conflict with other modules of the same name (module names are a
> > global namespace for modprobe).
> >
> > The way to make this a single module from four files is
> >
> > obj-$(CONFIG_IMX_SCU)          += imx-scu-mod.o
> > imx-scu-mod-y := imx-scu.o misc.o imx-scu-irq.o rm.o imx-scu-soc.o
>
> I haven't considered the support for loadable module of i.MX SCU firmware yet,
> plan to have another patch to do it, so do you think it is good to add the loadable
> module support together in this patch?

No, I wouldn't do that yet. It was just that adding the EXPORT_SYMBOL()
made it look like you were trying loadable module support already, and that
would not have been a good idea without changing the way it gets linked.

If you just remove the EXPORT_SYMBOL from this patch, it should be
fine, you can do the rest when you actually need the driver itself to be
loadable, and that in turn requires all drivers depending on it to
be loadable modules first.

      Arnd