linux-kernel - Re: [EXT] [PATCH] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a562bb9e-f158-3cdb-f969-fcbf88a2fad8@marvell.com>
Date:   Thu, 25 Jun 2020 19:32:28 +0300
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Colin King <colin.king@...onical.com>,
        Ariel Elior <aelior@...vell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Michal Kalderon <mkalderon@...vell.com>,
        <netdev@...r.kernel.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] [PATCH] qed: add missing error test for
 DBG_STATUS_NO_MATCHING_FRAMING_MODE

Hi Colin!

Thanks for catching this, indeed this was missed!

> 
>  	/* DBG_STATUS_INVALID_FILTER_TRIGGER_DWORDS */
>  	"The filter/trigger constraint dword offsets are not enabled for 
> recording",
> -
> +	/* DBG_STATUS_NO_MATCHING_FRAMING_MODE */
> +	"No matching framing mode",
> 

Could you please however change the string to

	"No matching framing mode found for the enabled blocks/Storms - use less
dwords for blocks data",

If you don't have much time, I can repost this for you. With this change it'll
 be in sync with our internal error descriptions.

Thanks
  Igor