linux-kernel - [PATCH 09/10] regulator: da9063-regulator: Fix .suspend 'initialized field overwritten' warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Jun 2020 17:36:13 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     lgirdwood@...il.com, broonie@...nel.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Lee Jones <lee.jones@...aro.org>
Subject: [PATCH 09/10] regulator: da9063-regulator: Fix .suspend 'initialized field overwritten' warnings

Looks as though 9f75ce666199 ("regulator: da9063: fix suspend") failed
to clean-up all of the existing .suspend variable initialisations.
This has led to some 'initilized field overwritten' issues now present
in W=1 builds.

This patch squashes the following build warnings:

 In file included from drivers/regulator/da9063-regulator.c:17:
 include/linux/regmap.h:1124:37: warning: initialized field overwritten [-Woverride-init]
 1124 | #define REG_FIELD(_reg, _lsb, _msb) { | ^
 drivers/regulator/da9063-regulator.c:27:2: note: in expansion of macro ‘REG_FIELD’
 27 | REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, | ^~~~~~~~~
 drivers/regulator/da9063-regulator.c:515:14: note: in expansion of macro ‘BFIELD’
 515 | .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL),
 | ^~~~~~
 include/linux/regmap.h:1124:37: note: (near initialization for ‘da9063_regulator_info[11].suspend’)
 1124 | #define REG_FIELD(_reg, _lsb, _msb) { | ^
 drivers/regulator/da9063-regulator.c:27:2: note: in expansion of macro ‘REG_FIELD’
 27 | REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, | ^~~~~~~~~
 drivers/regulator/da9063-regulator.c:515:14: note: in expansion of macro ‘BFIELD’
 515 | .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL),
 | ^~~~~~

Signed-off-by: Lee Jones <lee.jones@...aro.org>
---
 drivers/regulator/da9063-regulator.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
index e1d6c8f6d40bb..fe65b5acaf280 100644
--- a/drivers/regulator/da9063-regulator.c
+++ b/drivers/regulator/da9063-regulator.c
@@ -512,7 +512,6 @@ static const struct da9063_regulator_info da9063_regulator_info[] = {
 	},
 	{
 		DA9063_LDO(DA9063, LDO9, 950, 50, 3600),
-		.suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL),
 	},
 	{
 		DA9063_LDO(DA9063, LDO11, 900, 50, 3600),
-- 
2.25.1