[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20200625024207.1625-1-gaurav1086@gmail.com>
Date: Wed, 24 Jun 2020 22:42:05 -0400
From: Gaurav Singh <gaurav1086@...il.com>
To: gaurav1086@...il.com, Pablo Neira Ayuso <pablo@...filter.org>,
Jozsef Kadlecsik <kadlec@...filter.org>,
Florian Westphal <fw@...len.de>,
"David S. Miller" <davem@...emloft.net>,
Alexey Kuznetsov <kuznet@....inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
Jakub Kicinski <kuba@...nel.org>,
netfilter-devel@...r.kernel.org (open list:NETFILTER),
coreteam@...filter.org (open list:NETFILTER),
netdev@...r.kernel.org (open list:NETWORKING [IPv4/IPv6]),
linux-kernel@...r.kernel.org (open list)
Subject: [PATCH] [net/ipv6] remove redundant null check in frag_mt6
fh cannot be NULL since its already checked above after
assignment and is being dereferenced before. Remove the
redundant null check.
Signed-off-by: Gaurav Singh <gaurav1086@...il.com>
---
net/ipv6/netfilter/ip6t_frag.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv6/netfilter/ip6t_frag.c b/net/ipv6/netfilter/ip6t_frag.c
index fb91eeee4a1e..3aad6439386b 100644
--- a/net/ipv6/netfilter/ip6t_frag.c
+++ b/net/ipv6/netfilter/ip6t_frag.c
@@ -85,8 +85,7 @@ frag_mt6(const struct sk_buff *skb, struct xt_action_param *par)
!((fraginfo->flags & IP6T_FRAG_NMF) &&
(ntohs(fh->frag_off) & IP6_MF)));
- return (fh != NULL) &&
- id_match(fraginfo->ids[0], fraginfo->ids[1],
+ return id_match(fraginfo->ids[0], fraginfo->ids[1],
ntohl(fh->identification),
!!(fraginfo->invflags & IP6T_FRAG_INV_IDS)) &&
!((fraginfo->flags & IP6T_FRAG_RES) &&
--
2.17.1
Powered by blists - more mailing lists