linux-kernel - Re: [PATCH v1] ptp_pch: use generic power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200625.123604.1422188753260617907.davem@davemloft.net>
Date:   Thu, 25 Jun 2020 12:36:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vaibhavgupta40@...il.com
Cc:     helgaas@...nel.org, bhelgaas@...gle.com, bjorn@...gaas.com,
        vaibhav.varodek@...il.com, richardcochran@...il.com,
        linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        skhan@...uxfoundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH v1] ptp_pch: use generic power management

From: Vaibhav Gupta <vaibhavgupta40@...il.com>
Date: Thu, 25 Jun 2020 17:40:43 +0530

> With legacy PM, drivers themselves were responsible for managing the
> device's power states and takes care of register states.
> 
> After upgrading to the generic structure, PCI core will take care of
> required tasks and drivers should do only device-specific operations.
> 
> In the case of ptp_pch, after removing PCI helper functions, .suspend()
> and .resume() became empty-body functions. Hence, define them NULL and
> use dev_pm_ops.
> 
> Compile-tested only.
> 
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@...il.com>

A straight-forward transformation, looks good, applied to net-next
thanks.