linux-kernel - Re: [PATCH v2] kbuild: buildtar: add arm64 dtbs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Jun 2020 23:40:26 +0200
From:   Domenico Andreoli <domenico.andreoli@...ux.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Michal Marek <michal.lkml@...kovi.net>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Olof Johansson <olof@...om.net>,
        Will Deacon <will.deacon@....com>,
        Catalin Marinas <catalin.marinas@....com>
Subject: Re: [PATCH v2] kbuild: buildtar: add arm64 dtbs support

On Fri, Jun 26, 2020 at 03:16:58PM +0900, Masahiro Yamada wrote:
> On Fri, Jun 26, 2020 at 5:51 AM Domenico Andreoli
> <domenico.andreoli@...ux.com> wrote:
> >
> > From: Domenico Andreoli <domenico.andreoli@...ux.com>
> >
> > Make 'make tar-pkg' install dtbs on arm64.
> >
> > Signed-off-by: Domenico Andreoli <domenico.andreoli@...ux.com>
> >
> > v2:
> >  - Destination path includes the kernel version, as expected
> >
> > ---
> >  scripts/package/buildtar |    9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > Index: b/scripts/package/buildtar
> > ===================================================================
> > --- a/scripts/package/buildtar
> > +++ b/scripts/package/buildtar
> > @@ -125,6 +125,15 @@ case "${ARCH}" in
> >                 ;;
> >  esac
> >
> > +#
> > +# Install dtbs
> > +#
> > +case "${ARCH}" in
> 
> Instead of checking ${ARCH},
> can you you do
> 
>      if grep -q '^CONFIG_OF_EARLY_FLATTREE=y' include/config/auto.conf; then
> 
> ?

Done in v3.

> 
> This is what the deb package build does:
> https://github.com/masahir0y/linux/blob/v5.7/scripts/package/builddeb#L145
> 
> 
> > +       arm64)
> > +               make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_DTBS_PATH="${tmpdir}/boot/dtbs/${KERNELRELEASE}" dtbs_install
> > +               ;;
> > +esac
> > +
> 
> 
> Or, you can use INSTALL_PATH="${tmpdir}/boot"
> to make it shorter.

This does not work, INSTALL_DTBS_PATH gets somehow defined along the
twisted path to buildtar and therefore needs to be explicitly specified
for the new destination.

> --
> Best Regards
> Masahiro Yamada

Thank you for the review.

Regards,
Domenico

-- 
rsa4096: 3B10 0CA1 8674 ACBA B4FE  FCD2 CE5B CF17 9960 DE13
ed25519: FFB4 0CC3 7F2E 091D F7DA  356E CC79 2832 ED38 CB05