linux-kernel - Re: [RFC PATCH 10/11] efi: Rename arm-init to efi-init common for all arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOnJCU+=0Ozz=qfMULsN4-4rq_q4UFYsnkH50Bo5PfzUU45e6g@mail.gmail.com>
Date:   Fri, 26 Jun 2020 14:57:33 -0700
From:   Atish Patra <atishp@...shpatra.org>
To:     Heinrich Schuchardt <xypron.glpk@....de>
Cc:     Atish Patra <atish.patra@....com>,
        "linux-kernel@...r.kernel.org List" <linux-kernel@...r.kernel.org>,
        Ard Biesheuvel <ardb@...nel.org>,
        linux-efi <linux-efi@...r.kernel.org>,
        linux-riscv <linux-riscv@...ts.infradead.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Palmer Dabbelt <palmer@...belt.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [RFC PATCH 10/11] efi: Rename arm-init to efi-init common for all arch

On Thu, Jun 25, 2020 at 8:00 PM Heinrich Schuchardt <xypron.glpk@....de> wrote:
>
> On 6/26/20 1:45 AM, Atish Patra wrote:
> > arm-init is responsible for setting up efi runtime and doesn't actually
> > do any ARM specific stuff. RISC-V can use the same source code as it is.
> >
> > Rename it to efi-init so that RISC-V can use it.
> >
> > Signed-off-by: Atish Patra <atish.patra@....com>
> > ---
> >  drivers/firmware/efi/{arm-init.c => efi-init.c} | 0
> >  1 file changed, 0 insertions(+), 0 deletions(-)
> >  rename drivers/firmware/efi/{arm-init.c => efi-init.c} (100%)
> >
> > diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/efi-init.c
> > similarity index 100%
> > rename from drivers/firmware/efi/arm-init.c
> > rename to drivers/firmware/efi/efi-init.c
> >
>
> After each patch we should have code that builds. This helps when

Absolutely.

> bisecting. Therefore I would have expected an adjustment of
> drivers/firmware/efi/Makefile in this patch and not in patch 11/11:
>
> -arm-obj-$(CONFIG_EFI)                  := arm-init.o arm-runtime.o
> +arm-obj-$(CONFIG_EFI)                  := efi-init.o arm-runtime.o
>

I think I messed it up while rebasing. My bad. I will fix it in the
next version.

> Best regards
>
> Heinrich
>


-- 
Regards,
Atish