linux-kernel - Re: [PATCH 9/9] regulator: qcom_smd-regulator: Remove unused 'struct regulator_desc pmi8994

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Jun 2020 00:19:05 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     broonie@...nel.org, lgirdwood@...il.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Andy Gross <agross@...nel.org>, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 9/9] regulator: qcom_smd-regulator: Remove unused 'struct
 regulator_desc pmi8994_boost'

On Thu 25 Jun 23:57 PDT 2020, Lee Jones wrote:

> This was an upstreaming error.  Remove it as it's not to be used.
> 
> Fixes the following W=1 kernel build warning:
> 
>  drivers/regulator/qcom_smd-regulator.c:477:36: warning: ‘pmi8994_boost’ defined but not used [-Wunused-const-variable=]
> 
> Cc: Andy Gross <agross@...nel.org>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: linux-arm-msm@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Thanks,
Bjorn

> ---
>  drivers/regulator/qcom_smd-regulator.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
> index 53a64d856926f..4c0a469d8a115 100644
> --- a/drivers/regulator/qcom_smd-regulator.c
> +++ b/drivers/regulator/qcom_smd-regulator.c
> @@ -474,15 +474,6 @@ static const struct regulator_desc pmi8994_bby = {
>  	.ops = &rpm_bob_ops,
>  };
>  
> -static const struct regulator_desc pmi8994_boost = {
> -	.linear_ranges = (struct linear_range[]) {
> -		REGULATOR_LINEAR_RANGE(4000000, 0, 30, 50000),
> -	},
> -	.n_linear_ranges = 1,
> -	.n_voltages = 31,
> -	.ops = &rpm_smps_ldo_ops,
> -};
> -
>  static const struct regulator_desc pm8998_ftsmps = {
>  	.linear_ranges = (struct linear_range[]) {
>  		REGULATOR_LINEAR_RANGE(320000, 0, 258, 4000),
> -- 
> 2.25.1
>