linux-kernel - Re: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Jun 2020 09:36:57 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Phu Luu <Phu.Luu@...abs.com>
Cc:     "johan@...nel.org" <johan@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Brant Merryman <Brant.Merryman@...abs.com>,
        Richard Hendricks <Richard.Hendricks@...abs.com>,
        "hungnd3@...ft.com.vn" <hungnd3@...ft.com.vn>,
        Phú Lưu An <luuanphu@...il.com>
Subject: Re: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic
 throttle/unthrottle

On Fri, Jun 26, 2020 at 04:22:58AM +0000, Phu Luu wrote:
> From: Brant Merryman <brant.merryman@...abs.com>
> 
> Assign the .throttle and .unthrottle functions to be generic function
> in the driver structure to prevent data loss that can otherwise occur
> if the host does not enable USB throttling.
> 
> Signed-off-by: Phu Luu <phu.luu@...abs.com>
> Signed-off-by: Brant Merryman <brant.merryman@...abs.com>

Almost there. As I mentioned, the authori's SOB goes first and the
following SOB lines indicates who forwarded the patch (e.g. you in this
case).

If you also contributed to the patch you (e.g. you added the missing
changelog text) you should also add a Co-developed-by tag as described
in the process document I referred to:

	Co-developed-by: states that the patch was co-created by
	multiple developers; it is a used to give attribution to
	co-authors (in addition to the author attributed by the From:
	tag) when several people work on a single patch.  Since
	Co-developed-by: denotes authorship, every Co-developed-by: must
	be immediately followed by a Signed-off-by: of the associated
	co-author.  Standard sign-off procedure applies, i.e. the
	ordering of Signed-off-by: tags should reflect the chronological
	history of the patch insofar as possible, regardless of whether
	the author is attributed via From: or Co-developed-by:.
	Notably, the last Signed-off-by: must always be that of the
	developer submitting the patch.

	- Documentation/process/submitting-patches.rst

So in this case the tags should probably be:

	SOB: Brant
	CDB: Phu
	SOB: Phu

Care to fix that up in a v4 (yes, please increment the patch revision
every time you resubmit)?

Johan