linux-kernel - RE: [RESEND 09/10] regulator: da9063-regulator: Fix .suspend 'initialized field overwritten' warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR10MB2263AAC42CEE740F885526FA80930@AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM>
Date:   Fri, 26 Jun 2020 08:49:10 +0000
From:   Adam Thomson <Adam.Thomson.Opensource@...semi.com>
To:     Lee Jones <lee.jones@...aro.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Support Opensource <Support.Opensource@...semi.com>
Subject: RE: [RESEND 09/10] regulator: da9063-regulator: Fix .suspend
 'initialized field overwritten' warnings

On 25 June 2020 20:17, Lee Jones wrote:

> Looks as though 99f75ce666199 ("regulator: da9063: fix suspend") failed
> to clean-up all of the existing .suspend variable initialisations.
> This has led to some 'initilized field overwritten' issues now present
> in W=1 builds.

You probably were not on the CC but I believe the following patch has already
resolved this issue, and has been pulled by Mark:

 [PATCH] regulator: da9063: fix LDO9 suspend and warning.
 
 Repo: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/
 Branch: for-next
 Commit: d7442ba13d62de9afc4e57344a676f9f4623dcaa

> 
> This patch squashes the following build warnings:
> 
>  In file included from drivers/regulator/da9063-regulator.c:17:
>  include/linux/regmap.h:1124:37: warning: initialized field overwritten [-
> Woverride-init]
>  1124 | #define REG_FIELD(_reg, _lsb, _msb) { | ^
>  drivers/regulator/da9063-regulator.c:27:2: note: in expansion of macro
> ‘REG_FIELD’
>  27 | REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, | ^~~~~~~~~
>  drivers/regulator/da9063-regulator.c:515:14: note: in expansion of macro
> ‘BFIELD’
>  515 | .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL),
>  | ^~~~~~
>  include/linux/regmap.h:1124:37: note: (near initialization for
> ‘da9063_regulator_info[11].suspend’)
>  1124 | #define REG_FIELD(_reg, _lsb, _msb) { | ^
>  drivers/regulator/da9063-regulator.c:27:2: note: in expansion of macro
> ‘REG_FIELD’
>  27 | REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, | ^~~~~~~~~
>  drivers/regulator/da9063-regulator.c:515:14: note: in expansion of macro
> ‘BFIELD’
>  515 | .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL),
>  | ^~~~~~
> 
> Cc: Krystian Garbaciak <krystian.garbaciak@...semi.com>
> Cc: Support Opensource <support.opensource@...semi.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/regulator/da9063-regulator.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-
> regulator.c
> index e1d6c8f6d40bb..fe65b5acaf280 100644
> --- a/drivers/regulator/da9063-regulator.c
> +++ b/drivers/regulator/da9063-regulator.c
> @@ -512,7 +512,6 @@ static const struct da9063_regulator_info
> da9063_regulator_info[] = {
>  	},
>  	{
>  		DA9063_LDO(DA9063, LDO9, 950, 50, 3600),
> -		.suspend = BFIELD(DA9063_REG_LDO9_CONT,
> DA9063_VLDO9_SEL),
>  	},
>  	{
>  		DA9063_LDO(DA9063, LDO11, 900, 50, 3600),
> --
> 2.25.1