linux-kernel - Re: [v3] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Jun 2020 13:55:17 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Doug Anderson <dianders@...omium.org>,
        Harigovindan P <harigovi@...eaurora.org>,
        Andrzej Hajda <a.hajda@...sung.com>
Cc:     dri-devel <dri-devel@...ts.freedesktop.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        freedreno <freedreno@...ts.freedesktop.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        Rob Clark <robdclark@...il.com>,
        Sean Paul <seanpaul@...omium.org>,
        "Kristian H. Kristensen" <hoegsberg@...omium.org>,
        Kalyan Thota <kalyan_t@...eaurora.org>, nganji@...eaurora.org,
        Sam Ravnborg <sam@...nborg.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...l.net>
Subject: Re: [v3] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens
 during PM sleep

Hi,

On 19/06/2020 00:09, Doug Anderson wrote:
> Hi,
> 
> On Tue, Jun 9, 2020 at 5:05 AM Harigovindan P <harigovi@...eaurora.org> wrote:
>>
>> ti-sn65dsi86 bridge is enumerated as a runtime device. When
>> suspend is triggered, PM core adds a refcount on all the
>> devices and calls device suspend, since usage count is
>> already incremented, runtime suspend will not be called
>> and it kept the bridge regulators and gpios ON which resulted
>> in platform not entering into XO shutdown.
>>
>> Add changes to force suspend on the runtime device during pm sleep.
>>
>> Signed-off-by: Harigovindan P <harigovi@...eaurora.org>
>> ---
>>
>> Changes in v2:
>>         - Include bridge name in the commit message and
>>         remove dependent patchwork link from the commit
>>         text as bridge is independent of OEM(Stephen Boyd)
>>
>> Changes in v3:
>>         - Updating changelog to explain the need for patch
>>
>>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> I think this patch is good to go now (has both Stephen's and my
> reviews).  I noticed that Neil landed my other patches to this driver
> recently (thanks!) and wondered why he didn't land this one.  Then, I
> realized that you didn't send it to him or the other bridge
> maintainer.  :(  Have you tried running get_maintainer?
> 
> $ ./scripts/get_maintainer.pl -f drivers/gpu/drm/bridge/ti-sn65dsi86.c
> Andrzej Hajda <a.hajda@...sung.com> (maintainer:DRM DRIVERS FOR BRIDGE CHIPS)
> Neil Armstrong <narmstrong@...libre.com> (maintainer:DRM DRIVERS FOR
> BRIDGE CHIPS)
> Laurent Pinchart <Laurent.pinchart@...asonboard.com> (reviewer:DRM
> DRIVERS FOR BRIDGE CHIPS)
> Jonas Karlman <jonas@...boo.se> (reviewer:DRM DRIVERS FOR BRIDGE CHIPS)
> Jernej Skrabec <jernej.skrabec@...l.net> (reviewer:DRM DRIVERS FOR BRIDGE CHIPS)
> David Airlie <airlied@...ux.ie> (maintainer:DRM DRIVERS)
> Daniel Vetter <daniel@...ll.ch> (maintainer:DRM DRIVERS)
> dri-devel@...ts.freedesktop.org (open list:DRM DRIVERS)
> linux-kernel@...r.kernel.org (open list)
> 
> In any case, unless someone has extra feedback on this patch I think
> it's ready to land.
> 
> Neil: If you're willing to land this patch too, can you let
> Harigovindan know if it needs to be re-sent with you in the "To:" list
> or if you can find it on the dri-devel list?

Sorry missed this one,

Applying to drm-misc-next

Neil

> 
> Thanks!
> 
> -Doug
>