linux-kernel - Re: [PATCH 2/9] proc: add a read_iter method to proc proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200626120624.GL4332@42.do-not-panic.com>
Date:   Fri, 26 Jun 2020 12:06:24 +0000
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Christoph Hellwig <hch@....de>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Matthew Wilcox <willy@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        Iurii Zaikin <yzaikin@...gle.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 2/9] proc: add a read_iter method to proc proc_ops

On Fri, Jun 26, 2020 at 09:58:29AM +0200, Christoph Hellwig wrote:
> diff --git a/fs/proc/inode.c b/fs/proc/inode.c
> index 28d6105e908e4c..fa86619cebc2be 100644
> --- a/fs/proc/inode.c
> +++ b/fs/proc/inode.c
> @@ -297,6 +297,29 @@ static loff_t proc_reg_llseek(struct file *file, loff_t offset, int whence)
>  	return rv;
>  }
>  
> +static ssize_t pde_read_iter(struct proc_dir_entry *pde, struct kiocb *iocb,
> +		struct iov_iter *iter)
> +{
> +	if (!pde->proc_ops->proc_read_iter)
> +		return -EINVAL;

When is this true?

> +	return pde->proc_ops->proc_read_iter(iocb, iter);
> +}
> +

  Luis