[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200626133304.GB5289@sirena.org.uk>
Date: Fri, 26 Jun 2020 14:33:04 +0100
From: Mark Brown <broonie@...nel.org>
To: Lee Jones <lee.jones@...aro.org>
Cc: lgirdwood@...il.com, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, Russ Dill <Russ.Dill@...com>,
Keerthy <j-keerthy@...com>, AnilKumar Ch <anilkumar@...com>,
linux-omap@...r.kernel.org
Subject: Re: [PATCH 6/9] regulator: tps65217-regulator: Use the returned
value of tps65217_reg_read()
On Fri, Jun 26, 2020 at 07:57:35AM +0100, Lee Jones wrote:
> Until now the aforementioned return value has been ignored.
This is only aforementioned in the subject.
> /* Store default strobe info */
> ret = tps65217_reg_read(tps, regulators[i].bypass_reg, &val);
> + if (ret)
> + return ret;
> +
We should really be logging an error there rather than just returning,
that way it's a bit more apparent to someone debugging things what went
wrong if there is actually a problem.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists