linux-kernel - Re: [PATCH v7] hwmon: add Corsair Commander Pro driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1840543.YiJnzbJd1b@marius>
Date:   Fri, 26 Jun 2020 15:36:00 +0200
From:   Marius Zachmann <mail@...iuszachmann.de>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Jean Delvare <jdelvare@...e.com>, Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH v7] hwmon: add Corsair Commander Pro driver

On 26.06.20 at 15:21:35 CEST, Guenter Roeck wrote
> On Fri, Jun 26, 2020 at 07:59:36AM +0200, Marius Zachmann wrote:
> > This is v7 of a driver for the Corsair Commander Pro.
> 
> Note to self: Reword when applying.
> 
> > It provides sysfs attributes for:
> > - Reading fan speed
> > - Reading temp sensors
> > - Reading voltage values
> > - Writing pwm and reading last written pwm
> > - Reading fan and temp connection status
> > 
> > It is an usb driver, so it needs to be ignored by usbhid.
> > The Corsair Commander Pro is a fan controller and provides
> > no means for user interaction.
> > The two device numbers are there, because there is a slightly
> > different version of the same device. (Only difference
> > seem to be in some presets.)
> > 
> > This is based on the staging/hwmon tree.
> > 
> > Signed-off-by: Marius Zachmann <mail@...iuszachmann.de>
> 
> Looks good. For my reference:
> 
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> 
> We'll have to wait for an ACK from a HID maintainer before I can apply it.
> 
> Thanks,
> Guenter
> 

Thank you very much for your reviews and time!

Marius