lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Jun 2020 16:39:27 +0200 From: Arnd Bergmann <arnd@...db.de> To: Lee Jones <lee.jones@...aro.org> Cc: gregkh <gregkh@...uxfoundation.org>, Linux ARM <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Sudeep Dutt <sudeep.dutt@...el.com>, Ashutosh Dixit <ashutosh.dixit@...el.com>, Christian Borntraeger <borntraeger@...ibm.com> Subject: Re: [PATCH 07/10] misc: mic: vop: vop_main: Remove set but unused variable 'ret' On Fri, Jun 26, 2020 at 3:05 PM Lee Jones <lee.jones@...aro.org> wrote: > > Hasn't been checked since its conception 2 years ago. > > Squashes W=1 warning: > > drivers/misc/mic/vop/vop_main.c: In function ‘_vop_scan_devices’: > drivers/misc/mic/vop/vop_main.c:617:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > 617 | int ret; > | ^~~ > > Cc: Sudeep Dutt <sudeep.dutt@...el.com> > Cc: Ashutosh Dixit <ashutosh.dixit@...el.com> > Cc: Christian Borntraeger <borntraeger@...ibm.com> > Signed-off-by: Lee Jones <lee.jones@...aro.org> This is a correct change, but I'd take it one step further and make the _vop_remove_device() function return 'void' if you don't mind respinning the patch. Either way Acked-by: Arnd Bergmann <arnd@...db.de>
Powered by blists - more mailing lists