linux-kernel - Re: [PATCH] staging: media: usbvision: removing prohibited space before ',' (ctx:WxW)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Jun 2020 16:47:18 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Hans Verkuil <hverkuil@...all.nl>
Cc:     B K Karthik <bkkarthik@...u.pes.edu>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: media: usbvision: removing prohibited space
 before ',' (ctx:WxW)

On Fri, Jun 26, 2020 at 04:36:52PM +0200, Hans Verkuil wrote:
> On 26/06/2020 16:32, B K Karthik wrote:
> > fixing ERROR: space prohibited before that ',' (ctx:WxW)
> > 
> > Signed-off-by: B K Karthik <karthik.bk2000@...e.com>
> 
> usbvision is another driver that is scheduled for removal by the end of the year,
> so I won't apply this patch.
> 
> > ---
> >  drivers/staging/media/usbvision/usbvision-i2c.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/media/usbvision/usbvision-i2c.c b/drivers/staging/media/usbvision/usbvision-i2c.c
> > index 6e4df3335b1b..010ad03c6ec1 100644
> > --- a/drivers/staging/media/usbvision/usbvision-i2c.c
> > +++ b/drivers/staging/media/usbvision/usbvision-i2c.c
> > @@ -32,7 +32,7 @@ MODULE_PARM_DESC(i2c_debug, "enable debug messages [i2c]");
> >  #define PDEBUG(level, fmt, args...) { \
> >  		if (i2c_debug & (level)) \
> >  			printk(KERN_INFO KBUILD_MODNAME ":[%s:%d] " fmt, \
> > -				__func__, __LINE__ , ## args); \
> > +				__func__, __LINE__, ## args); \
> 
> Actually, older (buggy) gcc compiler needed a space there, if memory serves.

Yes, that will break on old versions of gcc.  crazy...