linux-kernel - Re: [PATCH 6/9] regulator: tps65217-regulator: Use the returned value of tps65217_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200626153119.GC177734@dell>
Date:   Fri, 26 Jun 2020 16:31:19 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     lgirdwood@...il.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Russ Dill <Russ.Dill@...com>,
        Keerthy <j-keerthy@...com>, AnilKumar Ch <anilkumar@...com>,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH 6/9] regulator: tps65217-regulator: Use the returned
 value of tps65217_reg_read()

On Fri, 26 Jun 2020, Mark Brown wrote:

> On Fri, Jun 26, 2020 at 07:57:35AM +0100, Lee Jones wrote:
> 
> > Until now the aforementioned return value has been ignored.
> 
> This is only aforementioned in the subject.
> 
> >  		/* Store default strobe info */
> >  		ret = tps65217_reg_read(tps, regulators[i].bypass_reg, &val);
> > +		if (ret)
> > +			return ret;
> > +
> 
> We should really be logging an error there rather than just returning,
> that way it's a bit more apparent to someone debugging things what went
> wrong if there is actually a problem.

Would you like me to fix that up subsequently?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog