linux-kernel - Re: [PATCH 1/7] floppy: use block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN4PR0401MB359889D1F40B3316A3E71A649B930@SN4PR0401MB3598.namprd04.prod.outlook.com>
Date:   Fri, 26 Jun 2020 15:50:55 +0000
From:   Johannes Thumshirn <Johannes.Thumshirn@....com>
To:     Christoph Hellwig <hch@....de>, "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/7] floppy: use block_size

On 26/06/2020 17:49, Johannes Thumshirn wrote:
> On 26/06/2020 10:03, Christoph Hellwig wrote:
>> -	size = bdev->bd_block_size;
>> -	if (!size)
>> -		size = 1024;
>> -
> 
> Why is this correct? block_size() only returns 'bdev->bd_block_size' but I cannot 
> see where it's made sure bd_block_size is not 0. At least no calls to set_blocksize()
> 
> 

OK answered the question myself. 

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>