linux-kernel - Re: [Patch v4 3/3] net: Restrict receive packets queuing to housekeeping CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200626.102038.1298513542272393362.davem@davemloft.net>
Date:   Fri, 26 Jun 2020 10:20:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     peterz@...radead.org
Cc:     nitesh@...hat.com, linux-kernel@...r.kernel.org,
        linux-api@...r.kernel.org, frederic@...nel.org,
        mtosatti@...hat.com, juri.lelli@...hat.com, abelits@...vell.com,
        bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        rostedt@...dmis.org, mingo@...nel.org, tglx@...utronix.de,
        akpm@...ux-foundation.org, sfr@...b.auug.org.au,
        stephen@...workplumber.org, rppt@...ux.vnet.ibm.com,
        jinyuqi@...wei.com, zhangshaokun@...ilicon.com
Subject: Re: [Patch v4 3/3] net: Restrict receive packets queuing to
 housekeeping CPUs

From: Peter Zijlstra <peterz@...radead.org>
Date: Fri, 26 Jun 2020 13:14:01 +0200

> On Thu, Jun 25, 2020 at 06:34:43PM -0400, Nitesh Narayan Lal wrote:
>> From: Alex Belits <abelits@...vell.com>
>> 
>> With the existing implementation of store_rps_map(), packets are queued
>> in the receive path on the backlog queues of other CPUs irrespective of
>> whether they are isolated or not. This could add a latency overhead to
>> any RT workload that is running on the same CPU.
>> 
>> Ensure that store_rps_map() only uses available housekeeping CPUs for
>> storing the rps_map.
>> 
>> Signed-off-by: Alex Belits <abelits@...vell.com>
>> Signed-off-by: Nitesh Narayan Lal <nitesh@...hat.com>
> 
> Dave, ACK if I route this?

No problem:

Acked-by: David S. Miller <davem@...emloft.net>