linux-kernel - Re: [PATCH 1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Jun 2020 22:07:27 +0300
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <maz@...nel.org>, Nishanth Menon <nm@...com>,
        Tero Kristo <t-kristo@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Lokesh Vutla <lokeshvutla@...com>
CC:     Xuefeng Li <lixuefeng@...ngson.cn>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/3] irqchip/ti-sci-inta: Remove dead code in
 ti_sci_inta_set_type()



On 06/06/2020 12:50, Tiezhu Yang wrote:
> In the function ti_sci_inta_set_type(), the statement "return -EINVAL;"
> out of switch case is dead code, remove it.
> 

Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver")
Right?

> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
>   drivers/irqchip/irq-ti-sci-inta.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
> index 7e3ebf6..c20c9f7 100644
> --- a/drivers/irqchip/irq-ti-sci-inta.c
> +++ b/drivers/irqchip/irq-ti-sci-inta.c
> @@ -433,8 +433,6 @@ static int ti_sci_inta_set_type(struct irq_data *data, unsigned int type)
>   	default:
>   		return -EINVAL;
>   	}
> -
> -	return -EINVAL;
>   }
>   
>   static struct irq_chip ti_sci_inta_irq_chip = {
> 

For all 3 patches:
Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>

And you might need re-send it with  --cover-letter
-- 
Best regards,
grygorii