linux-kernel - Re: [RESEND PATCH] irqchip/irq-mtk-sysirq: replace spinlock with raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <159325548742.93134.3774851842783687845.b4-ty@kernel.org>
Date:   Sat, 27 Jun 2020 12:08:01 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Jason Cooper <jason@...edaemon.net>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     Andrew Perepech <andrew.perepech@...iatek.com>,
        linux-mediatek@...ts.infradead.org,
        Stephane Le Provost <stephane.leprovost@...iatek.com>,
        linux-arm-kernel@...ts.infradead.org,
        Pedro Tsai <pedro.tsai@...iatek.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Fabien Parent <fparent@...libre.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] irqchip/irq-mtk-sysirq: replace spinlock with raw_spinlock

On Mon, 15 Jun 2020 09:44:45 +0200, Bartosz Golaszewski wrote:
> This driver may take a regular spinlock when a raw spinlock
> (irq_desc->lock) is already taken which results in the following
> lockdep splat:
> 
> =============================
> [ BUG: Invalid wait context ]
> 5.7.0-rc7 #1 Not tainted
> -----------------------------
> swapper/0/0 is trying to lock:
> ffffff800303b798 (&chip_data->lock){....}-{3:3}, at: mtk_sysirq_set_type+0x48/0xc0
> other info that might help us debug this:
> context-{5:5}
> 2 locks held by swapper/0/0:
>  #0: ffffff800302ee68 (&desc->request_mutex){....}-{4:4}, at: __setup_irq+0xc4/0x8a0
>  #1: ffffff800302ecf0 (&irq_desc_lock_class){....}-{2:2}, at: __setup_irq+0xe4/0x8a0
> stack backtrace:
> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.7.0-rc7 #1
> Hardware name: Pumpkin MT8516 (DT)
> Call trace:
>  dump_backtrace+0x0/0x180
>  show_stack+0x14/0x20
>  dump_stack+0xd0/0x118
>  __lock_acquire+0x8c8/0x2270
>  lock_acquire+0xf8/0x470
>  _raw_spin_lock_irqsave+0x50/0x78
>  mtk_sysirq_set_type+0x48/0xc0
>  __irq_set_trigger+0x58/0x170
>  __setup_irq+0x420/0x8a0
>  request_threaded_irq+0xd8/0x190
>  timer_of_init+0x1e8/0x2c4
>  mtk_gpt_init+0x5c/0x1dc
>  timer_probe+0x74/0xf4
>  time_init+0x14/0x44
>  start_kernel+0x394/0x4f0
> 
> [...]

Applied to irq/irqchip-5.9:

[1/1] irqchip/irq-mtk-sysirq: Replace spinlock with raw_spinlock
      commit: 6eeb997ab5075e770a002c51351fa4ec2c6b5c39

Thanks,

	M.
-- 
Without deviation from the norm, progress is not possible.