linux-kernel - Re: [PATCH v2 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 27 Jun 2020 14:43:59 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Rob Herring <robh+dt@...nel.org>, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: bmc150_magn: Document and fix
 missing compatibles

On Mon, 22 Jun 2020 08:01:09 +0200
Krzysztof Kozlowski <krzk@...nel.org> wrote:

> The driver supports also BMC156B and BMM150B but these compatibles had
> redundant suffix "_magn".  Add existing compatibles marking them
> deprecated along with adding a new, proper one for this family of
> devices.
Thanks for tidying this up.

The BMC156B is a dual magnetometer and accelerometer chip
so for that one the _magn postfix probably is needed.

Or am I missing something?

The way this does SPI is rather odd but seems to be the same as the bmc150
(two chips with non overlapping register maps).

Jonathan

> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> 
> ---
> 
> Changes since v1:
> 1. Mark old compatibles as deprecated, add new one.
> ---
>  .../devicetree/bindings/iio/magnetometer/bmc150_magn.txt    | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt b/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt
> index fd5fca90fb39..efeda055be6a 100644
> --- a/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt
> @@ -4,7 +4,11 @@ http://ae-bst.resource.bosch.com/media/products/dokumente/bmc150/BST-BMC150-DS00
>  
>  Required properties:
>  
> -  - compatible : should be "bosch,bmc150_magn"
> +  - compatible : should be one of:
> +                 "bosch,bmc150_magn"
> +                 "bosch,bmc156"
> +                 "bosch,bmc156_magn" (DEPRECATED, use bosch,bmc156)
> +                 "bosch,bmm150_magn" (DEPRECATED, use bosch,bmc156)
>    - reg : the I2C address of the magnetometer
>  
>  Optional properties: