linux-kernel - Re: [PATCH v3] media: venus: core: Fix runtime PM imbalance in venus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <9797fb44-e10e-61b5-b2cc-82d94cc98a3c@web.de>
Date:   Sun, 28 Jun 2020 15:16:23 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Dinghao Liu <dinghao.liu@....edu.cn>,
        linux-arm-msm@...r.kernel.org, linux-media@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Aditya Pakki <pakki001@....edu>,
        Navid Emamdoost <emamd001@....edu>, Kangjie Lu <kjlu@....edu>,
        Qiushi Wu <wu000273@....edu>, Andy Gross <agross@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Stanimir Varbanov <stanimir.varbanov@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: Re: [PATCH v3] media: venus: core: Fix runtime PM imbalance in
 venus_probe()

> when it returns an error code. Thus a pairing decrement is needed on

* I find it more appropriate to use the word “corresponding” here
  (if you do still not like previous wording suggestions).

* Will it become helpful to add the tag “Fixes” to the commit message?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=719fdd32921fb7e3208db8832d32ae1c2d68900f#n183

* Would you like to improve the change description any more?

> ---
>  drivers/media/platform/qcom/venus/core.c | 5 ++++-

I suggest replace the triple dashes before this diffstat by a blank line.

Regards,
Markus