linux-kernel - Re: [REPORT] False positive errors found while using scripts/checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <09010c9aa795a8dcbd4408ceb2a39ddc57c85037.camel@perches.com>
Date:   Sun, 28 Jun 2020 07:53:41 -0700
From:   Joe Perches <joe@...ches.com>
To:     B K Karthik <bkkarthik@...u.pes.edu>,
        Andy Whitcroft <apw@...onical.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [REPORT] False positive errors found while using
 scripts/checkpatch.pl

On Sun, 2020-06-28 at 10:00 -0400, B K Karthik wrote:
> The following are reported while using checkpatch.pl on 
> drivers/staging/fbtft/fbtft-bus.c
> 
> ERROR: space prohibited before that close parenthesis ')'
> #65: FILE: drivers/staging/fbtft/fbtft-bus.c:65:
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #67: FILE: drivers/staging/fbtft/fbtft-bus.c:67:
> +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
> 
> These are false positives as correcting these issues breaks the build.

Thanks, there's no capability to recognize this in checkpatch.
checkpatch is not a compiler.

Perhaps a reasonable solution is to add a comment around the
macro uses that show it's an unusual case.