linux-kernel - Re: [PATCH] kconfig: qconf: make debug links work again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200628175133.6a82ca42@coco.lan>
Date:   Sun, 28 Jun 2020 17:51:33 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To:     Maxim Levitsky <mlevitsk@...hat.com>
Cc:     Masahiro Yamada <masahiroy@...nel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kconfig: qconf: make debug links work again

Em Sun, 28 Jun 2020 17:48:08 +0300
Maxim Levitsky <mlevitsk@...hat.com> escreveu:

> On Sun, 2020-06-28 at 23:41 +0900, Masahiro Yamada wrote:
> > On Sun, Jun 28, 2020 at 9:21 PM Mauro Carvalho Chehab
> > <mchehab+huawei@...nel.org> wrote:  
> > > The Qt5 conversion broke support for debug info links.
> > > 
> > > Restore the behaviour added by changeset
> > > ab45d190fd4a ("kconfig: create links in info window").
> > > 
> > > Reported-by: Maxim Levitsky <mlevitsk@...hat.com>
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>  
> > 
> > I tested this patch, but this caused
> > segmentation fault.
> > 
> > 
> > I enabled 'Show Debug Info',
> > and then clicked
> > dep: <symbol name>.
> > 
> > Then, xconfig crashed.
> > 
> > (without this patch, it did not cause
> > segfault at least)
> > 
> > Did you see this?  
> 
> Works for me - tested this again 

It works for me too, but I'll double check. I don't actually like the
way it works, as it passes a pointer via the hyperlinks, instead of
some other type of reference, but this is the way the qt3 version
used to work.

I'll see if I can implement it on a different way, or at least add
some validation check.

Btw, what symbol did you click?

> (I have both patches applied on top on mainline master branch).
> Maybe you have Qt4?
> 
> One thing that I forgot to report is that when clicking on the symbol,
> only config descripion updates and not config/menu windows.
> It might even be always like that, I don't remember, but it would be nice if 
> these were updated too.

From what I saw this is the old behavior, at least as implemented on
changeset ab45d190fd4a ("kconfig: create links in info window").
See the implementation of ConfigInfoView::setSource() there.

I agree that it would be nice to change the other windows to reflect
it, but the goal of this patch is just to restore the old behavior.

A followup patch could be done later in order to improve it.

Regards,
Mauro