linux-kernel - Re: [PATCH 4/4] pwm: omap-dmtimer: Repair pwm_omap_dmtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200629193958.dasxmmkcexfxorfq@pengutronix.de>
Date:   Mon, 29 Jun 2020 21:39:58 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     thierry.reding@...il.com, linux-pwm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Tony Lindgren <tony@...mide.com>, NeilBrown <neilb@...e.de>,
        Grant Erickson <marathon96@...il.com>
Subject: Re: [PATCH 4/4] pwm: omap-dmtimer: Repair pwm_omap_dmtimer_chip's
 broken kerneldoc header

Hello,

[dropped Joachim Eastwood <manabian@...il.com> from recipents as his
address bounces]

On Mon, Jun 29, 2020 at 01:47:52PM +0100, Lee Jones wrote:
> Argument descriptions must be prepended with a '@' to be understood
> by the kerneldoc tooling/parsers/validators.
> 
> Fixes the following W=1 warning:
> 
>   drivers/pwm/pwm-omap-dmtimer.c:70: warning: Function parameter or member 'dm_timer_pdev' not described in 'pwm_omap_dmtimer_chip'
> 
> Cc: Tony Lindgren <tony@...mide.com>
> Cc: Joachim Eastwood <manabian@...il.com>
> Cc: NeilBrown <neilb@...e.de>
> Cc: Grant Erickson <marathon96@...il.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/pwm/pwm-omap-dmtimer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap-dmtimer.c
> index 0d31833db2e2c..75cea7f2aff5e 100644
> --- a/drivers/pwm/pwm-omap-dmtimer.c
> +++ b/drivers/pwm/pwm-omap-dmtimer.c
> @@ -58,7 +58,7 @@
>   * @mutex:		Mutex to protect pwm apply state
>   * @dm_timer:		Pointer to omap dm timer.
>   * @pdata:		Pointer to omap dm timer ops.
> - * dm_timer_pdev:	Pointer to omap dm timer platform device
> + * @dm_timer_pdev:	Pointer to omap dm timer platform device
>   */
>  struct pwm_omap_dmtimer_chip {
>  	struct pwm_chip chip;

LGTM,

Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)