linux-kernel - Re: [LKP] Re: [PATCH] crypto: af_alg - Fix regression on empty requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+G9fYszuzVq5P+10OA1biMQHQ-4tTDtqoOBHHdVMQXrwnWFJQ@mail.gmail.com>
Date:   Mon, 29 Jun 2020 14:23:02 +0530
From:   Naresh Kamboju <naresh.kamboju@...aro.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     LKML <linux-kernel@...r.kernel.org>, lkp@...ts.01.org,
        LTP List <ltp@...ts.linux.it>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        lkft-triage@...ts.linaro.org
Subject: Re: [LKP] Re: [PATCH] crypto: af_alg - Fix regression on empty requests

On Sat, 27 Jun 2020 at 14:02, Herbert Xu <herbert@...dor.apana.org.au> wrote:
>
> On Fri, Jun 26, 2020 at 04:29:48PM +1000, Herbert Xu wrote:
> >
> > Reported-by: Sachin Sant <sachinp@...ux.vnet.ibm.com>
> > Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> > Fixes: f3c802a1f300 ("crypto: algif_aead - Only wake up when...")
> > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
>
> Reported-by: kernel test robot <rong.a.chen@...el.com>
Tested-by: Naresh Kamboju <naresh.kamboju@...aro.org>

I have applied your patch and tested on Linux-next on arm, x86_64 and i386.
All LTP crypto tests got passed.

---
patch -p1 <  crypto-af_alg---Fix-regression-on-empty-requests.diff
patching file crypto/af_alg.c
patching file crypto/algif_aead.c
patching file crypto/algif_skcipher.c
patching file include/crypto/if_alg.h

Test output:
af_alg02.c:33: PASS: Successfully \"encrypted\" an empty message
af_alg05.c:40: PASS: read() expectedly failed with EINVAL

Test results summary:
af_alg01: pass
af_alg02: pass
af_alg03: pass
af_alg04: pass
af_alg05: pass
af_alg06: pass

ref:
https://lkft.validation.linaro.org/scheduler/job/1532020#L1413
https://lkft.validation.linaro.org/scheduler/job/1532019#L1516
https://lkft.validation.linaro.org/scheduler/job/1532026#L935

-- 
Linaro LKFT
https://lkft.linaro.org