linux-kernel - Re: [PATCH] thermal: sprd: Fix return value of sprd_thm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHLCerNwEefUG+bbWw6pd-jpBau8p2qs0Sd9f1yzx2iisCv01w@mail.gmail.com>
Date:   Mon, 29 Jun 2020 18:44:13 +0530
From:   Amit Kucheria <amit.kucheria@...aro.org>
To:     Baolin Wang <baolin.wang7@...il.com>
Cc:     Tiezhu Yang <yangtiezhu@...ngson.cn>,
        Zhang Rui <rui.zhang@...el.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [PATCH] thermal: sprd: Fix return value of sprd_thm_probe()

On Fri, May 29, 2020 at 7:55 PM Baolin Wang <baolin.wang7@...il.com> wrote:
>
> Hi,
>
> On Mon, May 25, 2020 at 10:00 AM Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:
> >
> > When call function devm_platform_ioremap_resource(), we should use IS_ERR()
> > to check the return value and return PTR_ERR() if failed.
> >
> > Fixes: 554fdbaf19b1 ("thermal: sprd: Add Spreadtrum thermal driver support")
> > Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
>
> Good catch. Thanks.
> Reviewed-by: Baolin Wang <baolin.wang7@...il.com>

Reviewed-by: Amit Kucheria <amit.kucheria@...aro.org>

> > ---
> >  drivers/thermal/sprd_thermal.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
> > index a340374..4cde70d 100644
> > --- a/drivers/thermal/sprd_thermal.c
> > +++ b/drivers/thermal/sprd_thermal.c
> > @@ -348,8 +348,8 @@ static int sprd_thm_probe(struct platform_device *pdev)
> >
> >         thm->var_data = pdata;
> >         thm->base = devm_platform_ioremap_resource(pdev, 0);
> > -       if (!thm->base)
> > -               return -ENOMEM;
> > +       if (IS_ERR(thm->base))
> > +               return PTR_ERR(thm->base);
> >
> >         thm->nr_sensors = of_get_child_count(np);
> >         if (thm->nr_sensors == 0 || thm->nr_sensors > SPRD_THM_MAX_SENSOR) {
> > --
> > 2.1.0
> >
>
>
> --
> Baolin Wang