linux-kernel - Re: [PATCH 10/20] misc: habanalabs: gaudi: gaudi_security: Repair incorrectly named function arg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFCwf11L35U4u-C+rKijJbPNc9VowFOaKWKzx=ZNY4cN=EkyBg@mail.gmail.com>
Date:   Mon, 29 Jun 2020 18:02:24 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-kernel@...ts.infradead.org,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        Tomer Tayar <ttayar@...ana.ai>
Subject: Re: [PATCH 10/20] misc: habanalabs: gaudi: gaudi_security: Repair
 incorrectly named function arg

On Mon, Jun 29, 2020 at 5:04 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> audi_pb_set_block()'s argument 'base' was incorrectly named 'block' in
gaudi_pb_set_block()'s

> its function header.
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/misc/habanalabs/gaudi/gaudi_security.c:454: warning: Function parameter or member 'base' not described in 'gaudi_pb_set_block'
>  drivers/misc/habanalabs/gaudi/gaudi_security.c:454: warning: Excess function parameter 'block' description in 'gaudi_pb_set_block'
>
> Cc: Oded Gabbay <oded.gabbay@...il.com>
> Cc: Tomer Tayar <ttayar@...ana.ai>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/misc/habanalabs/gaudi/gaudi_security.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/misc/habanalabs/gaudi/gaudi_security.c b/drivers/misc/habanalabs/gaudi/gaudi_security.c
> index 6a351e31fa6af..abdd5ed8f2cf6 100644
> --- a/drivers/misc/habanalabs/gaudi/gaudi_security.c
> +++ b/drivers/misc/habanalabs/gaudi/gaudi_security.c
> @@ -447,8 +447,7 @@ static u64 gaudi_rr_hbw_mask_high_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
>   * gaudi_set_block_as_protected - set the given block as protected
>   *
>   * @hdev: pointer to hl_device structure
> - * @block: block base address
> - *
> + * @base: block base address
>   */
>  static void gaudi_pb_set_block(struct hl_device *hdev, u64 base)
>  {
> --
> 2.25.1
>
With the above fix, This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@...il.com>