linux-kernel - Re: [PATCH v2 1/3] clk: JZ4780: Add functions for enable and disable USB PHY.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Jun 2020 17:28:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     周琰杰 (Zhou Yanjie) 
        <zhouyanjie@...yeetech.com>, linux-clk@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        sboyd@...nel.org, paul@...pouillou.net, mturquette@...libre.com,
        dongsheng.qiu@...enic.com, aric.pzqi@...enic.com,
        rick.tyliu@...enic.com, yanfei.li@...enic.com,
        sernia.zhou@...mail.com
Subject: Re: [PATCH v2 1/3] clk: JZ4780: Add functions for enable and disable
 USB PHY.

Hi "周琰杰,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on linux/master linus/master v5.8-rc3 next-20200629]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Zhou-Yanjie/Add-functions-to-operate-USB-PHY-related-clock/20200629-011858
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   In file included from arch/alpha/include/asm/bug.h:23,
                    from include/linux/bug.h:5,
                    from include/linux/thread_info.h:12,
                    from include/asm-generic/current.h:5,
                    from ./arch/alpha/include/generated/asm/current.h:1,
                    from include/linux/mutex.h:14,
                    from include/linux/kernfs.h:12,
                    from include/linux/sysfs.h:16,
                    from include/linux/kobject.h:20,
                    from include/linux/of.h:17,
                    from include/linux/clk-provider.h:9,
                    from drivers/clk/ingenic/jz4780-cgu.c:10:
   drivers/clk/ingenic/jz4780-cgu.c: In function 'jz4780_otg_phy_recalc_rate':
>> include/asm-generic/bug.h:127:34: error: expected expression before ')' token
     127 |  int __ret_warn_on = !!(condition);    \
         |                                  ^
>> drivers/clk/ingenic/jz4780-cgu.c:129:2: note: in expansion of macro 'WARN'
     129 |  WARN();
         |  ^~~~
   include/asm-generic/bug.h:88:51: error: expected expression before ')' token
      88 |   warn_slowpath_fmt(__FILE__, __LINE__, taint, arg); \
         |                                                   ^
   include/asm-generic/bug.h:129:3: note: in expansion of macro '__WARN_printf'
     129 |   __WARN_printf(TAINT_WARN, format);   \
         |   ^~~~~~~~~~~~~
>> drivers/clk/ingenic/jz4780-cgu.c:129:2: note: in expansion of macro 'WARN'
     129 |  WARN();
         |  ^~~~

vim +/WARN +129 drivers/clk/ingenic/jz4780-cgu.c

   105	
   106	static unsigned long jz4780_otg_phy_recalc_rate(struct clk_hw *hw,
   107							unsigned long parent_rate)
   108	{
   109		u32 usbpcr1;
   110		unsigned refclk_div;
   111	
   112		usbpcr1 = readl(cgu->base + CGU_REG_USBPCR1);
   113		refclk_div = usbpcr1 & USBPCR1_REFCLKDIV_MASK;
   114	
   115		switch (refclk_div) {
   116		case USBPCR1_REFCLKDIV_12:
   117			return 12000000;
   118	
   119		case USBPCR1_REFCLKDIV_24:
   120			return 24000000;
   121	
   122		case USBPCR1_REFCLKDIV_48:
   123			return 48000000;
   124	
   125		case USBPCR1_REFCLKDIV_19_2:
   126			return 19200000;
   127		}
   128	
 > 129		WARN();
   130		return parent_rate;
   131	}
   132	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (65024 bytes)