linux-kernel - Re: [PATCH 1/2] Input: add `SW_MACHINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fef69c79-9943-7bd1-5c51-101f551cf2c8@wizzup.org>
Date:   Mon, 29 Jun 2020 13:27:34 +0200
From:   Merlijn Wajer <merlijn@...zup.org>
To:     Pavel Machek <pavel@....cz>
Cc:     Sebastian Reichel <sebastian.reichel@...labora.com>,
        Tony Lindgren <tony@...mide.com>,
        Beno??t Cousson <bcousson@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Borislav Petkov <bp@...e.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Mattias Jacobsson <2pi@....nu>,
        Mark Gross <mgross@...ux.intel.com>,
        Russell King <rmk+kernel@...linux.org.uk>,
        "open list:OMAP DEVICE TREE SUPPORT" <linux-omap@...r.kernel.org>,
        "open list:OMAP DEVICE TREE SUPPORT" <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." 
        <linux-input@...r.kernel.org>
Subject: Re: [PATCH 1/2] Input: add `SW_MACHINE_COVER`

Hi,

Looks like we're blocking on this input patch.

On 16/06/2020 12:50, Pavel Machek wrote:
> On Fri 2020-06-12 14:53:58, Merlijn Wajer wrote:
>> This event code represents the state of a removable cover of a device.
>> Value 0 means that the cover is open or removed, value 1 means that the
>> cover is closed.
>>
>> Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com> Acked-by: Tony Lindgren 
>> <tony@...mide.com> Signed-off-by: Merlijn Wajer <merlijn@...zup.org> ---
> 
> Dmitry, can we get some kind of comment here, or better yet can we get you to apply this?

This is part of a patch series to resolve problems with the Nokia N900
not booting when the cover is removed (making the cover be the card
detect was also just weird IMHO). Just removing the card-detect from the
DTS is fine, but it was suggested that we expose the data instead as
input event. And that's gotten no response for about four months.

Should we just drop the feature and only remove the cd-gpios line from
the DTS, assuming upstream doesn't want this SW_MACHINE_COVER code?

Merlijn



Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)