linux-kernel - Re: [PATCH v4 2/6] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Jun 2020 16:07:37 -0600
From:   Rob Herring <robh@...nel.org>
To:     Wesley Cheng <wcheng@...eaurora.org>
Cc:     jackp@...eaurora.org, gregkh@...uxfoundation.org,
        rdunlap@...radead.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, lgirdwood@...il.com,
        linux-arm-msm@...r.kernel.org, broonie@...nel.org,
        robh+dt@...nel.org, devicetree@...r.kernel.org, agross@...nel.org,
        mark.rutland@....com, heikki.krogerus@...ux.intel.com,
        bjorn.andersson@...aro.org
Subject: Re: [PATCH v4 2/6] dt-bindings: usb: Add Qualcomm PMIC type C
 controller dt-binding

On Fri, 26 Jun 2020 11:55:12 -0700, Wesley Cheng wrote:
> Introduce the dt-binding for enabling USB type C orientation and role
> detection using the PM8150B.  The driver will be responsible for receiving
> the interrupt at a state change on the CC lines, reading the orientation/role,
> and communicating this information to the remote clients, which can include
> a role switch node and a type C switch.
> 
> Signed-off-by: Wesley Cheng <wcheng@...eaurora.org>
> ---
>  .../bindings/usb/qcom,pmic-typec.yaml         | 126 ++++++++++++++++++
>  1 file changed, 126 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> 


My bot found errors running 'make dt_binding_check' on your patch:

Documentation/devicetree/bindings/usb/qcom,pmic-typec.example.dts:40.54-42.31: Warning (unit_address_vs_reg): /example-0/pm8150b/typec@...0/connector/ports/port@...ndpoint@0: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/usb/qcom,pmic-typec.example.dts:43.51-45.31: Warning (unit_address_vs_reg): /example-0/pm8150b/typec@...0/connector/ports/port@...ndpoint@1: node has a unit name, but no reg or ranges property


See https://patchwork.ozlabs.org/patch/1317984

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.