linux-kernel - Re: [PATCH v2 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200629222612.pxbuuifod6tyudfu@liuwe-devbox-debian-v2>
Date:   Mon, 29 Jun 2020 22:26:12 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Haiyang Zhang <haiyangz@...rosoft.com>
Cc:     Andres Beltran <t-mabelt@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Michael Kelley <mikelley@...rosoft.com>,
        "parri.andrea@...il.com" <parri.andrea@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] hv_netvsc: Use vmbus_requestor to generate
 transaction IDs for VMBus hardening

On Mon, Jun 29, 2020 at 09:33:15PM +0000, Haiyang Zhang wrote:
> 
> 
> > -----Original Message-----
> > From: Andres Beltran <lkmlabelt@...il.com>
> > Sent: Monday, June 29, 2020 4:02 PM
> > To: KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> > <haiyangz@...rosoft.com>; Stephen Hemminger <sthemmin@...rosoft.com>;
> > wei.liu@...nel.org
> > Cc: linux-hyperv@...r.kernel.org; linux-kernel@...r.kernel.org; Michael
> > Kelley <mikelley@...rosoft.com>; parri.andrea@...il.com; Andres Beltran
> > <lkmlabelt@...il.com>; David S . Miller <davem@...emloft.net>; Jakub
> > Kicinski <kuba@...nel.org>; netdev@...r.kernel.org
> > Subject: [PATCH v2 3/3] hv_netvsc: Use vmbus_requestor to generate
> > transaction IDs for VMBus hardening
> > 
> > Currently, pointers to guest memory are passed to Hyper-V as
> > transaction IDs in netvsc. In the face of errors or malicious
> > behavior in Hyper-V, netvsc should not expose or trust the transaction
> > IDs returned by Hyper-V to be valid guest memory addresses. Instead,
> > use small integers generated by vmbus_requestor as requests
> > (transaction) IDs.
> > 
> > Cc: David S. Miller <davem@...emloft.net>
> > Cc: Jakub Kicinski <kuba@...nel.org>
> > Cc: netdev@...r.kernel.org
> > Signed-off-by: Andres Beltran <lkmlabelt@...il.com>
> 
> Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> 
> 

Thanks Haiyang for reviewing.

David and Jakub:

This patch depends on the first patch. I intend to pick up this patch
via hyperv.git. This makes life easier for all of us. Let me know if you
disagree.

Wei.