linux-kernel - Re: [RFC PATCH 1/2] Explicitly include linux/major.h where it is needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200630091203.55cdd5d9@canb.auug.org.au>
Date:   Tue, 30 Jun 2020 09:12:03 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Linux-kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arch@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [RFC PATCH 1/2] Explicitly include linux/major.h where it is
 needed

Hi Greg,

On Wed, 17 Jun 2020 07:58:43 +0200 Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Wed, Jun 17, 2020 at 09:27:47AM +1000, Stephen Rothwell wrote:
> > This is in preparation for removing the include of major.h where it is
> > not needed.
> > 
> > These files were found using
> > 
> > 	grep -E -L '[<"](uapi/)?linux/major\.h' $(git grep -l -w -f /tmp/xx)
> > 
> > where /tmp/xx contains all the symbols defined in major.h.  There were
> > a couple of files in that list that did not need the include since the
> > references are in comments.
> > 
> > Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>  
> 
> Any reason this had an RFC, but patch 2/2 did not?
> 
> They look good to me, I will be glad to take these, but do you still
> want reviews from others for this?  It seems simple enough to me...

I am going to do another round of this patchset splitting out most of
the "safe" removals that can be done anytime so other maintainers can
take them.  Then there will be the left over order dependent changes at
the end.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped