linux-kernel - RE: [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000301d64e0e$b9e32c70$2da98550$@codeaurora.org>
Date:   Mon, 29 Jun 2020 17:43:35 +0530
From:   "Rakesh Pillai" <pillair@...eaurora.org>
To:     "'Doug Anderson'" <dianders@...omium.org>,
        "'Kalle Valo'" <kvalo@...eaurora.org>
Cc:     <ath10k@...ts.infradead.org>,
        "'open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS'" 
        <devicetree@...r.kernel.org>,
        "'linux-wireless'" <linux-wireless@...r.kernel.org>,
        "'LKML'" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting



> -----Original Message-----
> From: Doug Anderson <dianders@...omium.org>
> Sent: Saturday, June 27, 2020 3:22 AM
> To: Rakesh Pillai <pillair@...eaurora.org>; Kalle Valo
> <kvalo@...eaurora.org>
> Cc: ath10k@...ts.infradead.org; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <devicetree@...r.kernel.org>; linux-wireless <linux-
> wireless@...r.kernel.org>; LKML <linux-kernel@...r.kernel.org>
> Subject: Re: [PATCH 2/2] ath10k: Add support for chain1 regulator supply
> voting
> 
> Hi,
> 
> On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai <pillair@...eaurora.org> wrote:
> >
> > Add support to vote for chain-1 voltage regulator
> > in WCN3990.
> >
> > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
> >
> > Signed-off-by: Rakesh Pillai <pillair@...eaurora.org>
> > ---
> >  drivers/net/wireless/ath/ath10k/snoc.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/wireless/ath/ath10k/snoc.c
> b/drivers/net/wireless/ath/ath10k/snoc.c
> > index 645ed5f..407a074 100644
> > --- a/drivers/net/wireless/ath/ath10k/snoc.c
> > +++ b/drivers/net/wireless/ath/ath10k/snoc.c
> > @@ -45,6 +45,7 @@ static const char * const ath10k_regulators[] = {
> >         "vdd-1.8-xo",
> >         "vdd-1.3-rfa",
> >         "vdd-3.3-ch0",
> > +       "vdd-3.3-ch1",
> 
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> 
> ...with the slight nit that ${SUBJECT} and description should probably
> call it "chan1" and not "chain1".  Presumably the maintainer can fix
> when applying.
> 
> -Doug

Hi Doug,

It has to be chain1 only, not chan1.
This is the power supply rail for the wlan-chain1