linux-kernel - Re: [PATCH RFC 2/2] s390/mm: don't set ARCH_KEEP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Jun 2020 15:02:30 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Heiko Carstens <heiko.carstens@...ibm.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-s390@...r.kernel.org, Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Philipp Rudo <prudo@...ux.ibm.com>,
        Michael Holzheu <holzheu@...ux.vnet.ibm.com>
Subject: Re: [PATCH RFC 2/2] s390/mm: don't set ARCH_KEEP_MEMBLOCK

On 29.06.20 14:44, Heiko Carstens wrote:
> On Fri, Jun 26, 2020 at 06:32:15PM +0200, Heiko Carstens wrote:
>> On Fri, Apr 17, 2020 at 05:01:51PM +0200, David Hildenbrand wrote:
>>> Commit 50be63450728 ("s390/mm: Convert bootmem to memblock") mentions
>>> 	"The original bootmem allocator is getting replaced by memblock. To
>>> 	cover the needs of the s390 kdump implementation the physical
>>> 	memory list is used."
>>>
>>> zcore was converted to use resources instead of memblocks.
>>> memblock_discard() will *not* mess with "physmem", only with "memory" and
>>> "reserved" memblocks. So, that data will stay after early boot, to be
>>> used in arch/s390/kernel/crash_dump.c to create the ELF header from
>>> inside the 2nd (a.k.a. dumping) kernel.
>>>
>>> We no longer need ARCH_KEEP_MEMBLOCK.
>>>
>>> Cc: Heiko Carstens <heiko.carstens@...ibm.com>
>>> Cc: Vasily Gorbik <gor@...ux.ibm.com>
>>> Cc: Christian Borntraeger <borntraeger@...ibm.com>
>>> Cc: Philipp Rudo <prudo@...ux.ibm.com>
>>> Cc: Michael Holzheu <holzheu@...ux.vnet.ibm.com>
>>> Signed-off-by: David Hildenbrand <david@...hat.com>
>>> ---
>>>  arch/s390/Kconfig | 1 -
>>>  1 file changed, 1 deletion(-)
>>
>> Applied, thanks!
> 
> Hmm, this triggers:

Ah, I see, will have a look. Weird I didn't notice that ...

Thanks!



-- 
Thanks,

David / dhildenb