[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <TY2PR01MB36925C9FF9C023C9FAD63D13D86E0@TY2PR01MB3692.jpnprd01.prod.outlook.com>
Date: Mon, 29 Jun 2020 02:49:30 +0000
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To: Mark Brown <broonie@...nel.org>
CC: "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
"lgirdwood@...il.com" <lgirdwood@...il.com>,
"geert+renesas@...der.be" <geert+renesas@...der.be>,
"magnus.damm@...il.com" <magnus.damm@...il.com>,
"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-renesas-soc@...r.kernel.org"
<linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH/RFC v4 3/4] mmc: core: Call mmc_poweroff_nofity() if
regulators are disabled
Hi Mark,
> From: Mark Brown, Sent: Saturday, June 27, 2020 12:14 AM
>
> On Fri, Jun 26, 2020 at 06:32:21PM +0900, Yoshihiro Shimoda wrote:
> > Note that this is possible to happen when the regulator-fixed driver
> > turns the vmmc and vqmmc off by firmware like PSCI while the system
> > is suspended.
>
> This is not a good interface, if there's a need to query the state over
> suspend then we should query the state over suspend rather than trying
> to somehow shoehorn it via the runtime enable state which is going to
> break any other users and relies on the regulator driver doing dodgy
> stuff representing the enable state.
I understood it.
So, as I mentioned other email thread, I'm thinking adding a new property
into MMC is better.
Best regards,
Yoshihiro Shimoda
Powered by blists - more mailing lists