linux-kernel - Re: [PATCH 2/4] pwm: bcm-kona: Remove impossible comparison when validating duty cycle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200629194113.5ppu6fbolvk2ibkj@pengutronix.de>
Date:   Mon, 29 Jun 2020 21:41:13 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Florian Fainelli <f.fainelli@...il.com>, thierry.reding@...il.com,
        linux-pwm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH 2/4] pwm: bcm-kona: Remove impossible comparison when
 validating duty cycle

On Mon, Jun 29, 2020 at 09:45:31AM -0700, Florian Fainelli wrote:
> 
> 
> On 6/29/2020 5:47 AM, Lee Jones wrote:
> > 'dc' here is an unsigned long, thus checking for <0 will always
> > evaluate to false.
> > 
> > Fixes the following W=1 warning:
> > 
> >  drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
> > 
> > Cc: Florian Fainelli <f.fainelli@...il.com>
> > Cc: Ray Jui <rjui@...adcom.com>
> > Cc: Scott Branden <sbranden@...adcom.com>
> > Cc: bcm-kernel-feedback-list@...adcom.com
> > Cc: linux-pwm@...r.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> 
> And similar to patch #1, DUTY_CYCLE_HIGH_MIN now gets unused, so if you
> remove it as well, you can add:
> 
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Even without removing DUTY_CYCLE_HIGH_MIN (which might still serve as
documentation):

Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)