linux-kernel - Re: [PATCH v2 3/3] clk: X1000: Add support for calculat REFCLK of USB PHY.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Jun 2020 21:20:50 +0800
From:   kernel test robot <lkp@...el.com>
To:     周琰杰 (Zhou Yanjie) 
        <zhouyanjie@...yeetech.com>, linux-clk@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-kernel@...r.kernel.org, sboyd@...nel.org,
        paul@...pouillou.net, mturquette@...libre.com,
        dongsheng.qiu@...enic.com, aric.pzqi@...enic.com,
        rick.tyliu@...enic.com, yanfei.li@...enic.com,
        sernia.zhou@...mail.com
Subject: Re: [PATCH v2 3/3] clk: X1000: Add support for calculat REFCLK of
 USB PHY.

Hi "周琰杰,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on linux/master linus/master v5.8-rc3 next-20200629]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Zhou-Yanjie/Add-functions-to-operate-USB-PHY-related-clock/20200629-011858
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: mips-randconfig-r012-20200629 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project a28d38a6bca1726d56c9b373f4c7dc5264fc7716)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/clk/ingenic/x1000-cgu.c:83:2: error: expected expression
           WARN();
           ^
   include/asm-generic/bug.h:127:34: note: expanded from macro 'WARN'
           int __ret_warn_on = !!(condition);                              \
                                           ^
>> drivers/clk/ingenic/x1000-cgu.c:83:2: error: expected expression
   include/asm-generic/bug.h:129:3: note: expanded from macro 'WARN'
                   __WARN_printf(TAINT_WARN, format);                      \
                   ^
   include/asm-generic/bug.h:88:51: note: expanded from macro '__WARN_printf'
                   warn_slowpath_fmt(__FILE__, __LINE__, taint, arg);      \
                                                                   ^
   2 errors generated.

vim +83 drivers/clk/ingenic/x1000-cgu.c

    62	
    63	static unsigned long x1000_otg_phy_recalc_rate(struct clk_hw *hw,
    64							unsigned long parent_rate)
    65	{
    66		u32 usbpcr1;
    67		unsigned refclk_div;
    68	
    69		usbpcr1 = readl(cgu->base + CGU_REG_USBPCR1);
    70		refclk_div = usbpcr1 & USBPCR1_REFCLKDIV_MASK;
    71	
    72		switch (refclk_div) {
    73		case USBPCR1_REFCLKDIV_12:
    74			return 12000000;
    75	
    76		case USBPCR1_REFCLKDIV_24:
    77			return 48000000;
    78	
    79		case USBPCR1_REFCLKDIV_48:
    80			return 48000000;
    81		}
    82	
  > 83		WARN();
    84		return parent_rate;
    85	}
    86	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (31039 bytes)