[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200630180411.GE37466@atomide.com>
Date: Tue, 30 Jun 2020 11:04:11 -0700
From: Tony Lindgren <tony@...mide.com>
To: Pavel Machek <pavel@....cz>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
Pavel Machek <pavel@...x.de>,
Merlijn Wajer <merlijn@...zup.org>, jikos@...e.cz,
vojtech@...e.cz,
Sebastian Reichel <sebastian.reichel@...labora.com>,
Beno??t Cousson <bcousson@...libre.com>,
Rob Herring <robh+dt@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Borislav Petkov <bp@...e.de>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
Thomas Gleixner <tglx@...utronix.de>,
Mattias Jacobsson <2pi@....nu>,
Mark Gross <mgross@...ux.intel.com>,
Russell King <rmk+kernel@...linux.org.uk>,
"open list:OMAP DEVICE TREE SUPPORT" <linux-omap@...r.kernel.org>,
"open list:OMAP DEVICE TREE SUPPORT" <devicetree@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>,
"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..."
<linux-input@...r.kernel.org>
Subject: Re: input maintainer -- are you there? was Re: [PATCH 1/2] Input:
add `SW_MACHINE_COVER`
* Pavel Machek <pavel@....cz> [200630 17:59]:
> Hi!
>
> > > > Looks like we're blocking on this input patch.
> > > >
> > > > On 16/06/2020 12:50, Pavel Machek wrote:
> > > > > On Fri 2020-06-12 14:53:58, Merlijn Wajer wrote:
> > > > >> This event code represents the state of a removable cover of a device.
> > > > >> Value 0 means that the cover is open or removed, value 1 means that the
> > > > >> cover is closed.
> > > > >>
> > > > >> Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com> Acked-by: Tony Lindgren
> > > > >> <tony@...mide.com> Signed-off-by: Merlijn Wajer <merlijn@...zup.org> ---
> > > > >
> > > > > Dmitry, can we get some kind of comment here, or better yet can we get you to apply this?
> > > >
> > > > This is part of a patch series to resolve problems with the Nokia N900
> > > > not booting when the cover is removed (making the cover be the card
> > > > detect was also just weird IMHO). Just removing the card-detect from the
> > > > DTS is fine, but it was suggested that we expose the data instead as
> > > > input event. And that's gotten no response for about four months.
> > > >
> > > > Should we just drop the feature and only remove the cd-gpios line from
> > > > the DTS, assuming upstream doesn't want this SW_MACHINE_COVER code?
> > >
> > > I believe series is good, lets keep it. Changing now will only delay
> > > it a bit more. Let me try to get Dmitry's attention...
> > >
> > > If that does not work, we can get Linus' attention :-).
> > >
> > > If that does not work, umm, there are some other options.
> >
> > Sorry, am really swamped the last couple months. I can pick up the input
> > code, do you want me to pick up DTS as well?
>
> No problem, sorry for being pushy.
>
> If you could pick up just the input one-liner, that would be best. It
> is not risky.
>
> OMAP people will take care of the DTS, I believe, and we can iterate
> if it does not work at the first try.
I already acked the dts change a while back, please just queue them
together. Or if you want me to pick it up, please set up an immutable
branch for me against v5.8-rc1 to also merge in :)
Regards,
Tony
Powered by blists - more mailing lists