linux-kernel - Re: [PATCH] udc: lpc32xx: mark local function static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6812131-1b40-a5bf-ede5-07a1ecde57dd@mleia.com>
Date:   Tue, 30 Jun 2020 21:32:26 +0300
From:   Vladimir Zapolskiy <vz@...ia.com>
To:     Arnd Bergmann <arnd@...db.de>, Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sylvain Lemieux <slemieux.tyco@...il.com>
Cc:     kernel test robot <lkp@...el.com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] udc: lpc32xx: mark local function static

Hi Arnd, thank you for the patch.

On 6/30/20 2:58 PM, Arnd Bergmann wrote:
> The kernel test robot reports two functions that should be marked
> static:
> 
>>> drivers/usb/gadget/udc/lpc32xx_udc.c:1928:6: warning: no previous prototype for 'udc_send_in_zlp' [-Wmissing-prototypes]
>     1928 | void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)
>>> drivers/usb/gadget/udc/lpc32xx_udc.c:1942:6: warning: no previous prototype for 'udc_handle_eps' [-Wmissing-prototypes]
>     1942 | void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)
> 
> This showed up after my commit 792e559e94bc ("udc: lpc32xx: fix 64-bit
> compiler warning") made it possible to build the driver on x86-64.
> 
> Fix the warning as suggested.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Vladimir Zapolskiy <vz@...ia.com>

--
Best wishes,
Vladimir