| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202006301145.GJO1ouSb%lkp@intel.com>
Date: Tue, 30 Jun 2020 11:00:50 +0800
From: kernel test robot <lkp@...el.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: drivers/phy/ti/phy-dm816x-usb.c:85:6: warning: variable 'error' set
but not used
Hi Krzysztof,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7c30b859a947535f2213277e827d7ac7dcff9c84
commit: 203b7ee14d3a38f1b8c44dd86ce0313d8fc4107d phy: Enable compile testing for some of drivers
date: 6 months ago
config: c6x-randconfig-r004-20200630 (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 203b7ee14d3a38f1b8c44dd86ce0313d8fc4107d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
<stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
drivers/phy/ti/phy-dm816x-usb.c: In function 'dm816x_usb_phy_init':
>> drivers/phy/ti/phy-dm816x-usb.c:85:6: warning: variable 'error' set but not used [-Wunused-but-set-variable]
85 | int error;
| ^~~~~
drivers/phy/ti/phy-ti-pipe3.c: In function 'ti_pipe3_power_on':
drivers/phy/ti/phy-ti-pipe3.c:340:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
340 | int ret;
| ^~~
drivers/phy/phy-core.c:1045: warning: Function parameter or member 'children' not described in '__devm_of_phy_provider_register'
drivers/phy/phy-core.c:1092: warning: Function parameter or member 'phy_provider' not described in 'devm_of_phy_provider_unregister'
drivers/phy/phy-xgene.c: In function 'xgene_phy_xlate':
drivers/phy/phy-xgene.c:1618:20: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
1618 | if (args->args[0] < MODE_SATA || args->args[0] >= MODE_MAX)
| ^
drivers/phy/marvell/phy-mvebu-a3700-utmi.c:84: warning: Function parameter or member 'usb_misc' not described in 'mvebu_a3700_utmi'
drivers/phy/samsung/phy-exynos5-usbdrd.c:211: warning: Function parameter or member 'phys' not described in 'exynos5_usbdrd_phy'
drivers/phy/samsung/phy-exynos5-usbdrd.c:211: warning: Function parameter or member 'vbus' not described in 'exynos5_usbdrd_phy'
drivers/phy/samsung/phy-exynos5-usbdrd.c:211: warning: Function parameter or member 'vbus_boost' not described in 'exynos5_usbdrd_phy'
drivers/phy/motorola/phy-mapphone-mdm6600.c:184: warning: Function parameter or member 'val' not described in 'phy_mdm6600_cmd'
drivers/phy/motorola/phy-mapphone-mdm6600.c:199: warning: Function parameter or member 'work' not described in 'phy_mdm6600_status'
drivers/phy/motorola/phy-mapphone-mdm6600.c:199: warning: Excess function parameter 'ddata' description in 'phy_mdm6600_status'
--
drivers/phy/ti/phy-dm816x-usb.c: In function 'dm816x_usb_phy_init':
>> drivers/phy/ti/phy-dm816x-usb.c:85:6: warning: variable 'error' set but not used [-Wunused-but-set-variable]
85 | int error;
| ^~~~~
drivers/phy/ti/phy-ti-pipe3.c: In function 'ti_pipe3_power_on':
drivers/phy/ti/phy-ti-pipe3.c:340:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
340 | int ret;
| ^~~
drivers/phy/phy-core.c:1045: warning: Function parameter or member 'children' not described in '__devm_of_phy_provider_register'
drivers/phy/phy-core.c:1092: warning: Function parameter or member 'phy_provider' not described in 'devm_of_phy_provider_unregister'
drivers/phy/phy-xgene.c: In function 'xgene_phy_xlate':
drivers/phy/phy-xgene.c:1618:20: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
1618 | if (args->args[0] < MODE_SATA || args->args[0] >= MODE_MAX)
| ^
drivers/phy/marvell/phy-mvebu-a3700-utmi.c:84: warning: Function parameter or member 'usb_misc' not described in 'mvebu_a3700_utmi'
drivers/phy/samsung/phy-exynos5-usbdrd.c:211: warning: Function parameter or member 'phys' not described in 'exynos5_usbdrd_phy'
drivers/phy/samsung/phy-exynos5-usbdrd.c:211: warning: Function parameter or member 'vbus' not described in 'exynos5_usbdrd_phy'
drivers/phy/samsung/phy-exynos5-usbdrd.c:211: warning: Function parameter or member 'vbus_boost' not described in 'exynos5_usbdrd_phy'
drivers/phy/motorola/phy-mapphone-mdm6600.c:184: warning: Function parameter or member 'val' not described in 'phy_mdm6600_cmd'
drivers/phy/motorola/phy-mapphone-mdm6600.c:199: warning: Function parameter or member 'work' not described in 'phy_mdm6600_status'
drivers/phy/motorola/phy-mapphone-mdm6600.c:199: warning: Excess function parameter 'ddata' description in 'phy_mdm6600_status'
--
drivers/phy/ti/phy-dm816x-usb.c: In function 'dm816x_usb_phy_init':
>> drivers/phy/ti/phy-dm816x-usb.c:85:6: warning: variable 'error' set but not used [-Wunused-but-set-variable]
85 | int error;
| ^~~~~
drivers/phy/ti/phy-ti-pipe3.c: In function 'ti_pipe3_power_on':
drivers/phy/ti/phy-ti-pipe3.c:340:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
340 | int ret;
| ^~~
--
drivers/phy/ti/phy-dm816x-usb.c: In function 'dm816x_usb_phy_init':
>> drivers/phy/ti/phy-dm816x-usb.c:85:6: warning: variable 'error' set but not used [-Wunused-but-set-variable]
85 | int error;
| ^~~~~
--
drivers/phy/phy-xgene.c: In function 'xgene_phy_xlate':
drivers/phy/phy-xgene.c:1618:20: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
1618 | if (args->args[0] < MODE_SATA || args->args[0] >= MODE_MAX)
| ^
drivers/phy/samsung/phy-exynos5-usbdrd.c:211: warning: Function parameter or member 'phys' not described in 'exynos5_usbdrd_phy'
drivers/phy/samsung/phy-exynos5-usbdrd.c:211: warning: Function parameter or member 'vbus' not described in 'exynos5_usbdrd_phy'
drivers/phy/samsung/phy-exynos5-usbdrd.c:211: warning: Function parameter or member 'vbus_boost' not described in 'exynos5_usbdrd_phy'
drivers/phy/ti/phy-dm816x-usb.c: In function 'dm816x_usb_phy_init':
>> drivers/phy/ti/phy-dm816x-usb.c:85:6: warning: variable 'error' set but not used [-Wunused-but-set-variable]
85 | int error;
| ^~~~~
drivers/phy/phy-core.c:1045: warning: Function parameter or member 'children' not described in '__devm_of_phy_provider_register'
drivers/phy/phy-core.c:1092: warning: Function parameter or member 'phy_provider' not described in 'devm_of_phy_provider_unregister'
drivers/phy/marvell/phy-mvebu-a3700-utmi.c:84: warning: Function parameter or member 'usb_misc' not described in 'mvebu_a3700_utmi'
drivers/phy/ti/phy-ti-pipe3.c: In function 'ti_pipe3_power_on':
drivers/phy/ti/phy-ti-pipe3.c:340:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
340 | int ret;
| ^~~
drivers/phy/motorola/phy-mapphone-mdm6600.c:184: warning: Function parameter or member 'val' not described in 'phy_mdm6600_cmd'
drivers/phy/motorola/phy-mapphone-mdm6600.c:199: warning: Function parameter or member 'work' not described in 'phy_mdm6600_status'
drivers/phy/motorola/phy-mapphone-mdm6600.c:199: warning: Excess function parameter 'ddata' description in 'phy_mdm6600_status'
make[3]: *** [scripts/Makefile.modfinal:41: drivers/phy/ti/phy-gmii-sel.ko] Error 1
make[3]: Target '__modfinal' not remade because of errors.
make[1]: *** [Makefile:1606: modules] Error 2
make[1]: Target '_all' not remade because of errors.
make[2]: *** [scripts/Makefile.modpost:95: __modpost] Error 2
c6x-elf-ld: unrecognised emulation mode: big-endian
Supported emulations: elf32_tic6x_elf_le elf32_tic6x_elf_be elf32_tic6x_le elf32_tic6x_be
--
drivers/phy/phy-xgene.c: In function 'xgene_phy_xlate':
drivers/phy/phy-xgene.c:1618:20: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
1618 | if (args->args[0] < MODE_SATA || args->args[0] >= MODE_MAX)
| ^
drivers/phy/samsung/phy-exynos5-usbdrd.c:211: warning: Function parameter or member 'phys' not described in 'exynos5_usbdrd_phy'
drivers/phy/samsung/phy-exynos5-usbdrd.c:211: warning: Function parameter or member 'vbus' not described in 'exynos5_usbdrd_phy'
drivers/phy/samsung/phy-exynos5-usbdrd.c:211: warning: Function parameter or member 'vbus_boost' not described in 'exynos5_usbdrd_phy'
drivers/phy/ti/phy-dm816x-usb.c: In function 'dm816x_usb_phy_init':
>> drivers/phy/ti/phy-dm816x-usb.c:85:6: warning: variable 'error' set but not used [-Wunused-but-set-variable]
85 | int error;
| ^~~~~
drivers/phy/phy-core.c:1045: warning: Function parameter or member 'children' not described in '__devm_of_phy_provider_register'
drivers/phy/phy-core.c:1092: warning: Function parameter or member 'phy_provider' not described in 'devm_of_phy_provider_unregister'
drivers/phy/marvell/phy-mvebu-a3700-utmi.c:84: warning: Function parameter or member 'usb_misc' not described in 'mvebu_a3700_utmi'
drivers/phy/ti/phy-ti-pipe3.c: In function 'ti_pipe3_power_on':
drivers/phy/ti/phy-ti-pipe3.c:340:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
340 | int ret;
| ^~~
drivers/phy/motorola/phy-mapphone-mdm6600.c:184: warning: Function parameter or member 'val' not described in 'phy_mdm6600_cmd'
drivers/phy/motorola/phy-mapphone-mdm6600.c:199: warning: Function parameter or member 'work' not described in 'phy_mdm6600_status'
drivers/phy/motorola/phy-mapphone-mdm6600.c:199: warning: Excess function parameter 'ddata' description in 'phy_mdm6600_status'
vim +/error +85 drivers/phy/ti/phy-dm816x-usb.c
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 80
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 81 static int dm816x_usb_phy_init(struct phy *x)
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 82 {
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 83 struct dm816x_usb_phy *phy = phy_get_drvdata(x);
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 84 unsigned int val;
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 @85 int error;
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 86
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 87 if (clk_get_rate(phy->refclk) != 24000000)
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 88 dev_warn(phy->dev, "nonstandard phy refclk\n");
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 89
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 90 /* Set PLL ref clock and put phys to sleep */
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 91 error = regmap_update_bits(phy->syscon, phy->usb_ctrl,
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 92 DM816X_USB_CTRL_PHYCLKSRC |
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 93 DM816X_USB_CTRL_PHYSLEEP1 |
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 94 DM816X_USB_CTRL_PHYSLEEP0,
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 95 0);
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 96 regmap_read(phy->syscon, phy->usb_ctrl, &val);
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 97 if ((val & 3) != 0)
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 98 dev_info(phy->dev,
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 99 "Working dm816x USB_CTRL! (0x%08x)\n",
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 100 val);
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 101
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 102 /*
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 103 * TI kernel sets these values for "symmetrical eye diagram and
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 104 * better signal quality" so let's assume somebody checked the
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 105 * values with a scope and set them here too.
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 106 */
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 107 regmap_read(phy->syscon, phy->usbphy_ctrl, &val);
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 108 val |= DM816X_USBPHY_CTRL_TXRISETUNE |
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 109 DM816X_USBPHY_CTRL_TXVREFTUNE |
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 110 DM816X_USBPHY_CTRL_TXPREEMTUNE;
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 111 regmap_write(phy->syscon, phy->usbphy_ctrl, val);
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 112
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 113 return 0;
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 114 }
609adde838f455 drivers/phy/phy-dm816x-usb.c Tony Lindgren 2015-03-19 115
:::::: The code at line 85 was first introduced by commit
:::::: 609adde838f4557f9d209b0432f4bac5c5eb5e86 phy: Add a driver for dm816x USB PHY
:::::: TO: Tony Lindgren <tony@...mide.com>
:::::: CC: Kishon Vijay Abraham I <kishon@...com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (33260 bytes)
Powered by blists - more mailing lists