linux-kernel - Re: [PATCH v3 01/15] mm,hwpoison: cleanup unused PageHuge() check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <890127ee-b6e1-9e96-d1dd-c04bd92f836f@oracle.com>
Date:   Tue, 30 Jun 2020 16:28:09 -0700
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     nao.horiguchi@...il.com, linux-mm@...ck.org
Cc:     mhocko@...nel.org, akpm@...ux-foundation.org, osalvador@...e.de,
        tony.luck@...el.com, david@...hat.com,
        aneesh.kumar@...ux.vnet.ibm.com, zeil@...dex-team.ru,
        naoya.horiguchi@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 01/15] mm,hwpoison: cleanup unused PageHuge() check

On 6/24/20 8:01 AM, nao.horiguchi@...il.com wrote:
> From: Naoya Horiguchi <naoya.horiguchi@....com>
> 
> Drop the PageHuge check, which is dead code since memory_failure() forks
> into memory_failure_hugetlb() for hugetlb pages.
> 
> memory_failure() and memory_failure_hugetlb() shares some functions like
> hwpoison_user_mappings() and identify_page_state(), so they should properly
> handle 4kB page, thp, and hugetlb.
> 
> Signed-off-by: Naoya Horiguchi <naoya.horiguchi@....com>
> Signed-off-by: Oscar Salvador <osalvador@...e.de>

Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>
-- 
Mike Kravetz