linux-kernel - Re: [PATCH v6 1/7] dt-bindings: pinctrl: add bindings for MediaTek MT6779 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1593489406.20357.3.camel@mtkswgap22>
Date:   Tue, 30 Jun 2020 11:56:46 +0800
From:   Hanks Chen <hanks.chen@...iatek.com>
To:     Rob Herring <robh@...nel.org>
CC:     <wsd_upstream@...iatek.com>, <linux-gpio@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>,
        "Michael Turquette" <mturquette@...libre.com>,
        Andy Teng <andy.teng@...iatek.com>,
        <linux-kernel@...r.kernel.org>,
        mtk01761 <wendell.lin@...iatek.com>,
        "Loda Chou" <loda.chou@...iatek.com>, <linux-clk@...r.kernel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Sean Wang <sean.wang@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        CC Hwang <cc.hwang@...iatek.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v6 1/7] dt-bindings: pinctrl: add bindings for MediaTek
 MT6779 SoC

On Mon, 2020-06-29 at 15:53 -0600, Rob Herring wrote:
> On Thu, 18 Jun 2020 19:33:32 +0800, Hanks Chen wrote:
> > From: Andy Teng <andy.teng@...iatek.com>
> > 
> > Add devicetree bindings for MediaTek MT6779 pinctrl driver.
> > 
> > Signed-off-by: Andy Teng <andy.teng@...iatek.com>
> > ---
> >  .../bindings/pinctrl/mediatek,mt6779-pinctrl.yaml  |  210 ++++++++++++++++++++
> >  1 file changed, 210 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
> > 
> 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.example.dts:21:18: fatal error: dt-bindings/pinctrl/mt6779-pinfunc.h: No such file or directory
>          #include <dt-bindings/pinctrl/mt6779-pinfunc.h>
>                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> scripts/Makefile.lib:315: recipe for target 'Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.example.dt.yaml' failed
> make[1]: *** [Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.example.dt.yaml] Error 1
> make[1]: *** Waiting for unfinished jobs....
> Makefile:1347: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
> 
> 
> See https://patchwork.ozlabs.org/patch/1312018
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
> 
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
> 
> Please check and re-submit.
> 
I already ran the dt_binding_check and it looks good.

> 
> 
> Here, you need patch 2 to come first or merge it into this patch as it 
> is part of the binding.
> 
I'll merge it into this patch in next version.
Thank you for your comment.

Hanks

> Rob
>